Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly implemented vsg::getDirectoryContents on the Windows platform #909

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

appcodegen
Copy link
Contributor

Description

This change uses the FindFirstFileW/FindNextFileW API function pair (with correct parameters) instead of FindFirstFileNameW/FindNextFileNameW (which only enumerates hard links and was using invalid parameters)

Fixes #905

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I tested this locally using a modified 'vsgviewer' example as there doesn't seem to be an example dedicated to Path/Paths/Filesystem classes/functions.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@robertosfield robertosfield merged commit 9185de6 into vsg-dev:master Aug 14, 2023
8 checks passed
@appcodegen appcodegen deleted the lrdev4 branch August 14, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vsg::getDirectoryContents is broken on Windows
2 participants