Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsg::getDirectoryContents is broken on Windows #905

Closed
appcodegen opened this issue Aug 14, 2023 · 1 comment · Fixed by #909
Closed

vsg::getDirectoryContents is broken on Windows #905

appcodegen opened this issue Aug 14, 2023 · 1 comment · Fixed by #909

Comments

@appcodegen
Copy link
Contributor

On the Windows platform this function simply does not do anything; to me it feels like someone just copied an API call and then only made sure it compiled ;)

Right now, the FindFirstFileNameW/FindNextFileNameW function pair is used, but with invalid parameters (required in/out parameters are simply set to nullptr). Note that I think these are actually the wrong functions, since these enumerate hard links only.

I think that actually the FindFirstFileW/FindNextFileW functions should be used.

I have a change here, I will see about creating a PR for this one

@robertosfield
Copy link
Collaborator

I had to implement it blind as I have only Linux systems here. I used the OpenSceneGraph implementation as starting place and got it compiling but have to rely upon the Windows community to help test/debug. I'd appreciate a PR fixing the problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants