Fedora/CentOS8: Ensure yum-utils/dnf-utils are present #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortuntely although CentOS 8 uses dnf, dnf-utils is actually provided by yum-utils. https://centos.pkgs.org/8/centos-baseos-x86_64/yum-utils-4.0.8-3.el8.noarch.rpm.html I've also fixed up the test a bit so that it checks to make sure yum-utils is actually installed on other OS versions.
|
For reference it looks like this changed in 8.1 - unsure of the reasoning: |
rcalixte
suggested changes
Jan 23, 2020
|
@rcalixte I've removed match for all of the RHEL derived Dists and moved the else conditional down to catch them just leaving the exception for fedora, seeing as that's the only one that's actually different now. |
bastelfreak
changed the title
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR will ensure that yum-utils gets installed on CentOS as unfortunately even on CentOS 8 this is still provided by yum-utils.
This Pull Request (PR) fixes the following issues
Fixes #158