Skip to content

Updated utils package for RHEL 8 #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2020
Merged

Updated utils package for RHEL 8 #137

merged 1 commit into from
Jan 20, 2020

Conversation

rcalixte
Copy link

@rcalixte rcalixte commented May 30, 2019 •
edited
Loading

Pull Request (PR) description

Updating -utils package for RHEL 8

This Pull Request (PR) fixes the following issues

N/A

@coreone
Copy link

coreone commented Aug 30, 2019

@alexjfisher is there any timeline on this getting merged to master? We are actively testing RHEL 8 and this would be extremely useful.

@vox-pupuli-tasks
Copy link

Dear @rcalixte, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

1 similar comment
@vox-pupuli-tasks
Copy link

Dear @rcalixte, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

bastelfreak
bastelfreak reviewed Jan 20, 2020
View reviewed changes
@bastelfreak bastelfreak added enhancement New feature or request needs-work not ready to merge just yet labels Jan 20, 2020
@rcalixte
Copy link
Author

@bastelfreak This should be good to merge after review. Thank you!

@alexjfisher alexjfisher mentioned this pull request Jan 20, 2020
Closed
@alexjfisher
Copy link
Member

@alexjfisher is there any timeline on this getting merged to master? We are actively testing RHEL 8 and this would be extremely useful.

Sorry I missed this. I was away at the time.

@alexjfisher
Copy link
Member

Looks like this PR has been updated to be based on #143 (which was recently merged)

@alexjfisher alexjfisher removed the needs-work not ready to merge just yet label Jan 20, 2020
dhollinger
dhollinger approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@dhollinger dhollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexjfisher alexjfisher merged commit b8fab4d into voxpupuli:master Jan 20, 2020
@rcalixte rcalixte deleted the rhel8 branch January 20, 2020 16:01
@alexjfisher
Copy link
Member

Apparently in EL 8.1 RedHat changed their minds??
See #159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak left review comments

@alexjfisher alexjfisher alexjfisher approved these changes

@dhollinger dhollinger dhollinger approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rcalixte @coreone @alexjfisher @bastelfreak @dhollinger