Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instantiate yumrepo & yum::config directly #148

Merged
merged 1 commit into from
Nov 13, 2019
Merged

instantiate yumrepo & yum::config directly #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions manifests/init.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,8 @@

$normalized_repos.each |$yumrepo, $attributes| {
if member($_managed_repos_minus_exclusions, $yumrepo) {
Resource['yumrepo'] {
$yumrepo: * => $attributes,
yumrepo { $yumrepo:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't quite identical behaviour. In the original form, I suspect there isn't a duplicate resource situation if the yumrepo has already been declared. On the other hand, I don't think this is actually the case here looking through 1fd551c

* => $attributes,
}
# Handle GPG Key
if ('gpgkey' in $attributes) {
Expand Down Expand Up @@ -183,8 +183,8 @@
}

$_normalized_config_options.each |$config, $attributes| {
Resource['yum::config'] {
$config: * => $attributes,
yum::config { $config:
* => $attributes,
}
}
}
Expand Down