instantiate yumrepo & yum::config directly #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're not doing any dynamic creation of potentially unknown resources, we want to use `yumrepo` and `yum::config` directly, rather than going thru `Resource`
alexjfisher
reviewed
Nov 12, 2019
| @@ -133,8 +133,8 @@ | |||
|
|
|||
| $normalized_repos.each |$yumrepo, $attributes| { | |||
| if member($_managed_repos_minus_exclusions, $yumrepo) { | |||
| Resource['yumrepo'] { | |||
| $yumrepo: * => $attributes, | |||
| yumrepo { $yumrepo: | |||
There was a problem hiding this comment.
This isn't quite identical behaviour. In the original form, I suspect there isn't a duplicate resource situation if the yumrepo has already been declared. On the other hand, I don't think this is actually the case here looking through 1fd551c
alexjfisher
approved these changes
Nov 12, 2019
|
@lamawithonel - let us know if we're accidentally breaking something! ;) |
|
I don't recall why I did that. I worked on a replacement lgtm 👍 |
|
@lamawithonel Many thanks for the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Since we're not doing any dynamic creation of potentially unknown
resources, we want to use
yumrepoandyum::configdirectly, ratherthan going thru
ResourceThis Pull Request (PR) fixes the following issues
none; only my confusion when reading the code.