Skip to content

Conversation

@wyardley
Copy link
Contributor

replaces #542

@wyardley
Copy link
Contributor Author

@olevole check out this one if you get a chance.

@wyardley wyardley mentioned this pull request Aug 25, 2017
@olevole
Copy link

olevole commented Aug 26, 2017

@wyardley Thanks! Looks good for me and my FBSD:

rabbit1:/root@[13:52] # uname -a
FreeBSD rabbit1.my.domain 12.0-CURRENT FreeBSD 12.0-CURRENT #0: Fri Aug 25 21:51:50 MSK 2017     [email protected]:/usr/obj/usr/jails/src/src_12/src/sys/CBSD  amd64

rabbit1:/root@[13:53] # puppet --version
4.10.6

rabbit1:/root@[13:53] # ps axf |grep erlan
32156  -  SJ   0:00.02 /usr/local/lib/erlang19/erts-8.3.5.2/bin/epmd -daemon
40005  -  IJ   0:05.10 /usr/local/lib/erlang19/erts-8.3.5.2/bin/beam.smp -W w -A 128 -P 1048576 -t 5000000 -stbt db -zdbbl 32000 -B i -- -root /usr/local/lib/erlang19 -progname erl -- -home /var/db/rabbitmq -- -pa /usr/local/lib/erlang/lib/rabbitmq_server-3.6.10/ebin -noshell -noinput -s rabbit boot -sname rabbit@rabbit1 -boot start_sasl -config /usr/local/etc/rabbitmq/rabbitmq -kernel inet_default_connect_options [{nodelay,true}] -sasl errlog_type error -sasl sasl_error_logger false -rabbit error_logger {file,"/var/log/rabbitmq/[email protected]"} -rabbit sasl_error_logger {file,"/var/log/rabbitmq/[email protected]"} -rabbit enabled_plugins_file "/usr/local/etc/rabbitmq/enabled_plugins" -rabbit plugins_dir "/usr/local/lib/erlang/lib/rabbitmq_server-3.6.10/plugins" -rabbit plugins_expand_dir "/var/db/rabbitmq/mnesia/rabbit@rabbit1-plugins-expand" -os_mon start_cpu_sup false -os_mon start_disksup false -os_mon start_memsup false -mnesia dir "/var/db/rabbitmq/mnesia/rabbit@rabbit1" -kernel inet_dist_listen_min 25672 -kernel inet_dist_listen_max 25672 inet_dist_listen_max 25672

rabbit1:/root@[13:53] # pkg info |grep rabbit
rabbitmq-3.6.10_1              RabbitMQ is an implementation of AMQP

@wyardley wyardley force-pushed the freebsd branch 2 times, most recently from 074b529 to adc72fd Compare August 30, 2017 20:03
@wyardley wyardley added the enhancement New feature or request label Aug 30, 2017
]
},
{
"operatingsystem": "FreeBSD"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

freebsd isnt rolling release (well, kind of), so we shul list the versions we support. same for openbsd

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wasn't sure which versions this would work with, and was mostly relying on examples from other modules. Because of the ports system, my guess is that the range of present and future supported versions might be pretty broad, though I don't know how far back we'd want to support.

I do use FreeBSD and OpenBSD (FBSD since the 4.x days), but not with Puppet, so I didn't really know what values are reasonable here. Suggestions or PR to my PR are welcome 😉

end

def with_freebsd_facts
# operatingsystemmajrelease is too broad
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we mock stuff here that is totally different in the real world, depending on the freebsd trouble? does it bring us into trouble?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite sure I follow?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the facts we simulate here used? If so, we should probably simulate them correctly, for all supported freebsd versions (or rely on rspec-puppet-facts)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ps - reformatted this one. I think they are (like the other OSes in this file) valid, but not the only possible value.
For example, we support CentOS 6, but only supply facts for 7.

@bastelfreak bastelfreak merged commit df85ca5 into voxpupuli:master Aug 30, 2017
@wyardley wyardley deleted the freebsd branch September 1, 2017 14:17
slm0n87 pushed a commit to slm0n87/puppet-rabbitmq that referenced this pull request Mar 7, 2019
cegeka-jenkins pushed a commit to cegeka/puppet-rabbitmq that referenced this pull request Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants