add FreeBSD support #542
add FreeBSD support #542
Conversation
| should contain_package('rabbitmq-server').with( | ||
| 'ensure' => 'installed', | ||
| 'name' => 'rabbitmq', | ||
| 'provider' => 'freebsd' |
There was a problem hiding this comment.
This is why your test is failing, it's expecting pkgng.
Though I think provider isn't actually needed. Not sure if #493 will get merged, but would have to adjust slightly to get FreeBSD support working if / when that gets merged.
| $package_name = 'rabbitmq' | ||
| $service_name = 'rabbitmq' | ||
| $package_provider = 'pkgng' | ||
| $version = '3.4.2' |
There was a problem hiding this comment.
Also, keep in mind that while $version is used internally as things work now, it's ignored when using the system package provider, so it doesn't really matter in this case.
|
ps - https://github.com/voxpupuli/puppet-rabbitmq/blob/master/metadata.json may also need to be updated (FreeBSD and OpenBSD support are both not currently included there) |
|
@olevole would you like to rework this one? If not, I can give a quick go at reworking it and submitting a new PR. |
|
@wyardley Hi Will! |
|
I can take a stab at it once #493 is merged, shouldn't be hard. |
|
@olevole ps - one question, though - is |
|
Haven't submitted yet, but check out this: |
|
reworking via #567 |
2 participants
No description provided.