Skip to content

Allow management_port to be a string; require stdlib >= 4.25.0 #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2018
Merged

Allow management_port to be a string; require stdlib >= 4.25.0 #275

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a84897a
Allow management_port to be a string. [Fix #274]
jiuka Apr 5, 2018
09c6a0c
Be more specific about the allowed values for management_port.
jiuka Aug 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/server.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,7 @@
String $pam_module_arguments = 'login',
Boolean $management = false,
String $management_ip = 'localhost',
Integer $management_port = 7505,
Variant[Integer,String] $management_port = 7505,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any string valid, or only 'unix'? Otherwise we could do something like Variant[Integer,Enum['unix']].

Could you also enhance this by removing the Integer type and replace it with Stdlib::Port::Unprivileged from https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/types/port/unprivileged.pp ? This requires a bump of the minimal stdlib version to 4.25.0 in the metadata.json:

puppet-openvpn/metadata.json

Line 56 in 4814cd7

"version_requirement": ">= 4.13.1 < 5.0.0"

String $up = '',
String $down = '',
Boolean $username_as_common_name = false,
Expand Down