Allow management_port to be a string; require stdlib >= 4.25.0 #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Aug 12, 2018
manifests/server.pp
Outdated
| @@ -478,7 +478,7 @@ | |||
| String $pam_module_arguments = 'login', | |||
| Boolean $management = false, | |||
| String $management_ip = 'localhost', | |||
| Integer $management_port = 7505, | |||
| Variant[Integer,String] $management_port = 7505, | |||
There was a problem hiding this comment.
Is there any string valid, or only 'unix'? Otherwise we could do something like Variant[Integer,Enum['unix']].
Could you also enhance this by removing the Integer type and replace it with Stdlib::Port::Unprivileged from https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/types/port/unprivileged.pp ? This requires a bump of the minimal stdlib version to 4.25.0 in the metadata.json:
Line 56 in 4814cd7
bastelfreak
added
enhancement
bastelfreak
changed the title
bastelfreak
changed the title
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the
management_portparameter to be a string too. This fixed #274