Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to ETA v0.13.1 #5305

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Bump to ETA v0.13.1 #5305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions fiftyone/core/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -973,19 +973,6 @@ def __init__(self, total=None, progress=None, quiet=None, **kwargs):
self._progress = progress
self._callback = callback

def __call__(self, iterable):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer needed; this is now handled by voxel51/eta@9b4db83

# Ensure that `len(iterable)` is not computed unnecessarily
no_len = self._quiet and self._total is None
if no_len:
self._total = -1

super().__call__(iterable)

if no_len:
self._total = None

return self

def set_iteration(self, *args, **kwargs):
super().set_iteration(*args, **kwargs)

Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def get_version():
# internal packages
"fiftyone-brain>=0.18.2,<0.19",
"fiftyone-db>=0.4,<2.0",
"voxel51-eta>=0.13.0,<0.14",
"voxel51-eta>=0.13.1,<0.14",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Version 0.13.1 is not yet available on PyPI

The requested version voxel51-eta>=0.13.1 cannot be used as a dependency because:

  • The latest available version on PyPI is 0.13.0 (released on September 16, 2024)
  • Version 0.13.1 does not exist in the package releases

Please update the dependency to use the currently available version >=0.13.0,<0.14 or ensure version 0.13.1 is published to PyPI before merging this change.

🔗 Analysis chain

LGTM! Let's verify the new version requirement.

The version bump from >=0.13.0 to >=0.13.1 follows semantic versioning and maintains API compatibility.

Let's verify the version exists and check for any known issues:

Let me verify the latest available version of voxel51-eta.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify voxel51-eta version 0.13.1 exists and check for any known issues

# Check if the version exists on PyPI
curl -s https://pypi.org/pypi/voxel51-eta/json | jq '.releases | has("0.13.1")'

# Check the release date and download stats for this version
curl -s https://pypi.org/pypi/voxel51-eta/0.13.1/json | jq '{upload_time: .urls[0].upload_time, downloads: .urls[0].downloads}'

# Look for any issues mentioning this version
gh api graphql -f query='
{
  search(query: "repo:voxel51/eta is:issue 0.13.1", type: ISSUE, first: 5) {
    nodes {
      ... on Issue {
        title
        state
        url
      }
    }
  }
}'

Length of output: 498

Script:

#!/bin/bash
# Check available versions of voxel51-eta
curl -s https://pypi.org/pypi/voxel51-eta/json | jq '.releases | keys[]' | sort -V

# Check the latest version's upload time and downloads
curl -s https://pypi.org/pypi/voxel51-eta/json | jq -r '.urls[0] | {upload_time, filename}'

Length of output: 773

]


Expand Down
Loading