Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to ETA v0.13.1 #5305

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Bump to ETA v0.13.1 #5305

merged 1 commit into from
Dec 20, 2024

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Dec 20, 2024

This optimizes dataset.first() by ensuring that len(dataset) is not called unnecessarily.

@brimoor brimoor requested a review from findtopher December 20, 2024 12:06
Copy link
Contributor

coderabbitai bot commented Dec 20, 2024

Walkthrough

The pull request introduces modifications to two files: fiftyone/core/utils.py and setup.py. In utils.py, the ProgressBar class undergoes a simplification by removing the __call__ method, which previously handled iterable length computation. The setup.py file sees a minor update to the version constraint for the voxel51-eta package, incrementing the minimum version from 0.13.0 to 0.13.1.

Changes

File Change Summary
fiftyone/core/utils.py Removed __call__ method from ProgressBar class, simplifying progress bar functionality
setup.py Updated voxel51-eta package version constraint from >=0.13.0,<0.14 to >=0.13.1,<0.14

Possibly related PRs

Suggested reviewers

  • findtopher
  • sashankaryal

Poem

🐰 A rabbit's progress bar tale,
Simplified code without a wail,
Version bumped with gentle care,
Dependencies dancing in the air,
Coding magic beyond compare! 🚀

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@@ -973,19 +973,6 @@ def __init__(self, total=None, progress=None, quiet=None, **kwargs):
self._progress = progress
self._callback = callback

def __call__(self, iterable):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer needed; this is now handled by voxel51/eta@9b4db83

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e5cd1bd and 4953b31.

📒 Files selected for processing (2)
  • fiftyone/core/utils.py (0 hunks)
  • setup.py (1 hunks)
💤 Files with no reviewable changes (1)
  • fiftyone/core/utils.py

@@ -76,7 +76,7 @@ def get_version():
# internal packages
"fiftyone-brain>=0.18.2,<0.19",
"fiftyone-db>=0.4,<2.0",
"voxel51-eta>=0.13.0,<0.14",
"voxel51-eta>=0.13.1,<0.14",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Version 0.13.1 is not yet available on PyPI

The requested version voxel51-eta>=0.13.1 cannot be used as a dependency because:

  • The latest available version on PyPI is 0.13.0 (released on September 16, 2024)
  • Version 0.13.1 does not exist in the package releases

Please update the dependency to use the currently available version >=0.13.0,<0.14 or ensure version 0.13.1 is published to PyPI before merging this change.

🔗 Analysis chain

LGTM! Let's verify the new version requirement.

The version bump from >=0.13.0 to >=0.13.1 follows semantic versioning and maintains API compatibility.

Let's verify the version exists and check for any known issues:


Let me verify the latest available version of voxel51-eta.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify voxel51-eta version 0.13.1 exists and check for any known issues

# Check if the version exists on PyPI
curl -s https://pypi.org/pypi/voxel51-eta/json | jq '.releases | has("0.13.1")'

# Check the release date and download stats for this version
curl -s https://pypi.org/pypi/voxel51-eta/0.13.1/json | jq '{upload_time: .urls[0].upload_time, downloads: .urls[0].downloads}'

# Look for any issues mentioning this version
gh api graphql -f query='
{
  search(query: "repo:voxel51/eta is:issue 0.13.1", type: ISSUE, first: 5) {
    nodes {
      ... on Issue {
        title
        state
        url
      }
    }
  }
}'

Length of output: 498


Script:

#!/bin/bash
# Check available versions of voxel51-eta
curl -s https://pypi.org/pypi/voxel51-eta/json | jq '.releases | keys[]' | sort -V

# Check the latest version's upload time and downloads
curl -s https://pypi.org/pypi/voxel51-eta/json | jq -r '.urls[0] | {upload_time, filename}'

Length of output: 773

Copy link
Member

@findtopher findtopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

voxel51-eta v0.13.1 has been published

@brimoor brimoor merged commit 50970e9 into release/v1.2.0 Dec 20, 2024
13 of 14 checks passed
@brimoor brimoor deleted the bugfix/dataset-first branch December 20, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants