Address issue #136: order type definitions #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will do the other types next. Just wanted to start this. |
|
|
||
| <xs:simpleType name="IdentifierType"> | ||
| <xs:restriction base="xs:string"> | ||
| <xs:enumeration value="ocd-id" /> |
There was a problem hiding this comment.
Are you ordering the enums only by the name of the enum, or by the name of the enum and then the values of the enum (with 'other' always last)?
There was a problem hiding this comment.
I am only ordering the "chunks" in this PR and not changing the internal ordering of any type or enum definitions (which can happen in subsequent PR's if needed).
|
I believe this is done now (just ordering the types). Name changes can occur in subsequent PRs. |
|
LGTM |
cjerdonek
added a commit
that referenced
this pull request
May 1, 2015
…r-type-defs Address issue #136: order type definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue #136.