Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order type definitions in XSD #136

Closed
cjerdonek opened this issue May 1, 2015 · 8 comments
Closed

Order type definitions in XSD #136

cjerdonek opened this issue May 1, 2015 · 8 comments
Milestone

Comments

@cjerdonek
Copy link
Contributor

We need to order the type definitions in the XSD per the style guide. Is it okay for me to do this, or is someone else already working on a big change to the XSD?

@jdmgoogle
Copy link
Contributor

Not sure what the status is of @pstenbjorn's Venetian-Blind-izing the XSD.

@pstenbjorn
Copy link
Contributor

@cjerdonek @jdmgoogle Venetian Blinding is merged. I am fine with @cjerdonek ordering the XSD.

@cjerdonek
Copy link
Contributor Author

I will create a PR now.

@cjerdonek
Copy link
Contributor Author

Started PR #137.

@jdmgoogle
Copy link
Contributor

Since this should be a relatively non-controversial set of PRs (i.e., just sorting some elements and attributes), would @jungshadow or @pstenbjorn object if we waived the normal two-reviewer rule and I reviewed @cjerdonek's PRs by myself?

@jungshadow
Copy link
Collaborator

Fine by me.

@pstenbjorn
Copy link
Contributor

Same here

cjerdonek added a commit that referenced this issue May 1, 2015
…r-type-defs

Address issue #136: order type definitions
@cjerdonek
Copy link
Contributor Author

Closed by PR #137.

@jdmgoogle jdmgoogle modified the milestone: Version 5.0 May 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants