Downgrade decimal version before decompose interface #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any version after ericlagergren/decimal#124 causes problems when saving Decimal to sql drivers like postgres. While the best solution may be to update all the sql drivers, it has been 3 years since then, so it is better to make sure the latest version does not have that commit. This version is the latest before it.
zhongduo
commented
Jul 15, 2023
| @@ -454,8 +454,6 @@ github.com/volatiletech/null/v8 v8.1.2/go.mod h1:98DbwNoKEpRrYtGjWFctievIfm4n4Mx | |||
| github.com/volatiletech/randomize v0.0.1 h1:eE5yajattWqTB2/eN8df4dw+8jwAzBtbdo5sbWC4nMk= | |||
| github.com/volatiletech/randomize v0.0.1/go.mod h1:GN3U0QYqfZ9FOJ67bzax1cqZ5q2xuj2mXrXBjWaRTlY= | |||
| github.com/volatiletech/strmangle v0.0.1/go.mod h1:F6RA6IkB5vq0yTG4GQ0UsbbRcl3ni9P76i+JrTBKFFg= | |||
| github.com/volatiletech/strmangle v0.0.4 h1:CxrEPhobZL/PCZOTDSH1aq7s4Kv76hQpRoTVVlUOim4= | |||
There was a problem hiding this comment.
this is deleted by go mod tidy
|
Other related issues from this: |
|
@stephenafamo while I am can modify my local go.mod for my project, I think it makes sense to make sure the latest version of sqlboiler will just work. Today if someone use the latest version, they will always hit this problem. |
|
@stephenafamo thanks for merging this. I would also suggest to cut a new version to stop the bleeding for new users. But obviously it depends on the release schedule. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any version after ericlagergren/decimal#124 causes problems when saving Decimal to sql drivers like postgres. While the best solution may be to update all the sql drivers, it has been 3 years since then, so it is better to make sure the latest version does not have that commit. This version is the latest before it.
close #803