Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decimal: add decomposer interface #124

Merged
merged 1 commit into from
Jul 24, 2019
Merged

decimal: add decomposer interface #124

merged 1 commit into from
Jul 24, 2019

Conversation

kardianos
Copy link
Contributor

@kardianos
Copy link
Contributor Author

Let me know if you think this interface will work.

@kardianos kardianos mentioned this pull request Apr 6, 2019
Open
@kardianos kardianos force-pushed the kardianos-decomposer branch 3 times, most recently from d916040 to c4e47de Compare April 6, 2019 23:46
@kardianos kardianos marked this pull request as ready for review April 9, 2019 22:08
ericlagergren
ericlagergren previously approved these changes Apr 20, 2019
View reviewed changes
@kardianos kardianos force-pushed the kardianos-decomposer branch 2 times, most recently from 4137310 to 3627411 Compare May 4, 2019 06:51
@kardianos
Copy link
Contributor Author

Hi @ericlagergren , could you take another look?

@ericlagergren
Copy link
Owner

It looks good to me! I’ve just been waiting for the green light to merge it :D

@kardianos
Copy link
Contributor Author

You have a green light from me :)
This is merged in two fixed precision packages and coachroachdb/apd.

@ericlagergren ericlagergren merged commit 50723dc into ericlagergren:master Jul 24, 2019
@ericlagergren
Copy link
Owner

@kardianos how would you like me to list you, if at all, in the CONTRIBUTORS file?

@kardianos
Copy link
Contributor Author

If you want, you could list "Daniel Theophanes [email protected]".

zhongduo added a commit to zhongduo/sqlboiler that referenced this pull request Jul 15, 2023
@zhongduo
Downgrade decimal version before decompose interface
bc59c15 
Any version after ericlagergren/decimal#124
causes problems when saving Decimal to sql drivers like postgres. While
the best solution may be to update all the sql drivers, it has been 3
years since then, so it is better to make sure the latest version does
not have that commit. This version is the latest before it.
@zhongduo zhongduo mentioned this pull request Jul 15, 2023
Merged
@zhongduo
Copy link

@kardianos @ericlagergren it has been three years since this PR is introduced, is there any plan to fix all the sql drivers etc? Currently it is failing tools like sqlboiler or likely anything without proper driver support. If no one is driving to update those drivers it likely won't happen. If the interest of continuing this work is low, I would suggest to revert this change so people other package can use the latest version. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericlagergren ericlagergren ericlagergren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kardianos @ericlagergren @zhongduo