Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing phosphor widgets js #116

Closed
timkpaine opened this issue Apr 16, 2019 · 2 comments · Fixed by #183
Closed

Missing phosphor widgets js #116

timkpaine opened this issue Apr 16, 2019 · 2 comments · Fixed by #183

Comments

@timkpaine
Copy link
Member

We separated the jupyterlab ipywidget from our phosphor bindings from our perspective library, which has the effect of introducing an explicit dependency on phosphor which seems to be failing. Any insights on how we might rectify this?

image
@timkpaine
Copy link
Member Author

Maybe because it doesnt export a dist? https://unpkg.com/@phosphor/[email protected]/dist/index.js

@timkpaine timkpaine mentioned this issue Apr 16, 2019
Closed
@timkpaine timkpaine reopened this Apr 17, 2019
@timkpaine
Copy link
Member Author

I'm trying out a few things but I don't think you want to grab phosphor from unpkg anyway. So I'm trying to register it in the same way you register the jupyter-widgets code in libwidgets. Any other thoughts or ideas are much appreciated!

SylvainCorlay pushed a commit to SylvainCorlay/voila that referenced this issue Jun 4, 2019
@timkpaine @SylvainCorlay
fixes voila-dashboards#116
d9b662d
@SylvainCorlay SylvainCorlay mentioned this issue Jun 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose phosphor SylvainCorlay/voila
1 participant
@timkpaine