Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failover embed to lib after dist #2381

Closed
timkpaine opened this issue Apr 16, 2019 · 5 comments
Closed

Failover embed to lib after dist #2381

timkpaine opened this issue Apr 16, 2019 · 5 comments
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.

Comments

@timkpaine
Copy link
Contributor

Looks like we've hit a weird case with voila where we need to grab phosphor. The problem is libembed only checks unpkg for dist/index.js, but phosphor builds into lib/index.js. Is it possible to failover to lib here if the call to dist 404s?

@timkpaine
Copy link
Contributor Author

@timkpaine
Copy link
Contributor Author

@timkpaine
Copy link
Contributor Author

@jasongrout @maartenbreddels @SylvainCorlay open to suggestions for other fixes as well

@timkpaine
Copy link
Contributor Author

Root cause is unrelated to this (voila-dashboards/voila#122) but we've had this issue with other stuff in the past, so still worth considering ( see this issue)

@timkpaine
Copy link
Contributor Author

Closing as unfixed in case someone happens on this later, I'm gonna use phoila which supports installed bundles

@lock lock bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

1 participant