Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: fix npm lint warnings #1808

Merged
merged 3 commits into from
Apr 5, 2023
Merged

frontend: fix npm lint warnings #1808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d191a7
frontend: fix linter and sca warnings
Mar 29, 2023
02993b3
Merge branch 'main' into person/mdilyan/fe-lint-and-sa
DeltaMichael Apr 4, 2023
e7a6f92
Merge branch 'main' into person/mdilyan/fe-lint-and-sa
DeltaMichael Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion .../data-job/pages/executions/data-job-executions-page/data-job-executions-page.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ export class DataJobExecutionsPageComponent
OnTaurusModelInit,
OnTaurusModelLoad,
OnTaurusModelChange,
OnTaurusModelError
OnTaurusModelError,
OnInit
ivakoleva marked this conversation as resolved.
Show resolved Hide resolved
{
readonly uuid = 'DataJobExecutionsPageComponent';

Expand Down
6 changes: 3 additions & 3 deletions ...s/data-pipelines/src/lib/components/data-job/pages/executions/model/data-job-execution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ export class DataJobExecutionToGridDataJobExecution {
}
}

static convertToDataJobExecution(
static convertToDataJobExecution = (
DeltaMichael marked this conversation as resolved.
Show resolved Hide resolved
dataJobExecution: DataJobExecutions,
): GridDataJobExecution[] {
): GridDataJobExecution[] => {
const formatDeltaPipe = new FormatDeltaPipe();

return dataJobExecution.reduce((accumulator, execution) => {
Expand All @@ -65,7 +65,7 @@ export class DataJobExecutionToGridDataJobExecution {

return accumulator;
}, [] as GridDataJobExecution[]);
}
};

static getStatusColorsMap() {
return {
Expand Down
6 changes: 3 additions & 3 deletions ...frontend/data-pipelines/gui/projects/data-pipelines/src/lib/shared/utils/data-job.util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ export class DataJobUtil {
/**
* ** Predicate for Job Running.
*/
static isJobRunningPredicate(
static isJobRunningPredicate = (
DeltaMichael marked this conversation as resolved.
Show resolved Hide resolved
jobExecution: DataJobExecution | DataJobExecutionDetails,
): boolean {
): boolean => {
return (
(jobExecution as DataJobExecution).status ===
DataJobExecutionStatus.RUNNING ||
Expand All @@ -34,7 +34,7 @@ export class DataJobUtil {
(jobExecution as DataJobExecutionDetails).status ===
DataJobExecutionStatusDeprecated.SUBMITTED
);
}
};

/**
* ** Find if some Job is running in provided Executions.
Expand Down
2 changes: 1 addition & 1 deletion ...ents/gui/projects/shared/src/lib/features/placeholder/components/placeholder.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ const ErrorEscalation: PlaceholderAutoSupportedStates = {

const ErrorImgSource: PlaceholderAutoSupportedStates = {
Generic: 'assets/images/placeholder/server-error.svg',
Offline: null,
Offline: '',
DeltaMichael marked this conversation as resolved.
Show resolved Hide resolved
NotFound: 'assets/images/placeholder/not-found.svg'
};

Expand Down