frontend: fix npm lint warnings #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivakoleva
approved these changes
Mar 31, 2023
...nts/data-job/pages/executions/data-job-executions-page/data-job-executions-page.component.ts
Show resolved
Hide resolved
murphp15
reviewed
Mar 31, 2023
...ponents/gui/projects/shared/src/lib/features/placeholder/components/placeholder.component.ts
Show resolved
Hide resolved
murphp15
approved these changes
Mar 31, 2023
gorankokin
reviewed
Mar 31, 2023
...ts/frontend/data-pipelines/gui/projects/data-pipelines/src/lib/shared/utils/data-job.util.ts
Show resolved
Hide resolved
gorankokin
reviewed
Mar 31, 2023
...frontend/data-pipelines/gui/projects/data-pipelines/src/lib/model/toast-definitions.model.ts
Outdated
Show resolved
Hide resolved
projects/frontend/data-pipelines/gui/projects/data-pipelines/src/lib/data-pipelines.module.ts
Outdated
Show resolved
Hide resolved
...lines/src/lib/components/data-jobs-manage/components/grid/data-jobs-manage-grid.component.ts
Outdated
Show resolved
Hide resolved
...ects/data-pipelines/src/lib/components/data-job/pages/executions/model/data-job-execution.ts
Show resolved
Hide resolved
.../data-pipelines/src/lib/components/data-job/pages/details/data-job-details-page.component.ts
Outdated
Show resolved
Hide resolved
.../data-pipelines/src/lib/components/data-job/pages/details/data-job-details-page.component.ts
Outdated
Show resolved
Hide resolved
...-pipelines/src/lib/components/data-job/pages/details/data-job-details-page.component.spec.ts
Outdated
Show resolved
Hide resolved
...-pipelines/src/lib/components/data-job/pages/details/data-job-details-page.component.spec.ts
Outdated
Show resolved
Hide resolved
...pipelines/gui/projects/data-pipelines/src/lib/components/data-job/data-job-page.component.ts
Outdated
Show resolved
Hide resolved
Fix the following npm lint warnings:
/Users/mdilyan/Projects/versatile-data-kit/projects/frontend/data-pipelines/gui/projects/data-pipelines/src/lib/components/data-job/data-job-page.component.ts
27:30 warning '/Users/mdilyan/Projects/versatile-data-kit/projects/frontend/data-pipelines/gui/node_modules/@versatiledatakit/shared/fesm2015/versatiledatakit-shared.mjs' imported multiple times import/no-duplicates
45:8 warning '/Users/mdilyan/Projects/versatile-data-kit/projects/frontend/data-pipelines/gui/node_modules/@versatiledatakit/shared/fesm2015/versatiledatakit-shared.mjs' imported multiple times import/no-duplicates
708:33 warning Avoid referencing unbound methods which may cause unintentional scoping of `this`.
If your function does not access `this`, you can annotate it with `this: void`, or consider using an arrow function instead @typescript-eslint/unbound-method
/Users/mdilyan/Projects/versatile-data-kit/projects/frontend/data-pipelines/gui/projects/data-pipelines/src/lib/components/data-job/pages/details/data-job-details-page.component.spec.ts
14:42 warning '/Users/mdilyan/Projects/versatile-data-kit/projects/frontend/data-pipelines/gui/node_modules/@versatiledatakit/shared/fesm2015/versatiledatakit-shared.mjs' imported multiple times import/no-duplicates
27:8 warning '/Users/mdilyan/Projects/versatile-data-kit/projects/frontend/data-pipelines/gui/node_modules/@versatiledatakit/shared/fesm2015/versatiledatakit-shared.mjs' imported multiple times import/no-duplicates
/Users/mdilyan/Projects/versatile-data-kit/projects/frontend/data-pipelines/gui/projects/data-pipelines/src/lib/components/data-job/pages/details/data-job-details-page.component.ts
16:8 warning '/Users/mdilyan/Projects/versatile-data-kit/projects/frontend/data-pipelines/gui/node_modules/@versatiledatakit/shared/fesm2015/versatiledatakit-shared.mjs' imported multiple times import/no-duplicates
35:8 warning '/Users/mdilyan/Projects/versatile-data-kit/projects/frontend/data-pipelines/gui/node_modules/@versatiledatakit/shared/fesm2015/versatiledatakit-shared.mjs' imported multiple times import/no-duplicates
335:21 warning Avoid referencing unbound methods which may cause unintentional scoping of `this`.
If your function does not access `this`, you can annotate it with `this: void`, or consider using an arrow function instead @typescript-eslint/unbound-method
/Users/mdilyan/Projects/versatile-data-kit/projects/frontend/data-pipelines/gui/projects/data-pipelines/src/lib/components/data-job/pages/executions/data-job-execution-status/data-job-execution-status.component.html
16:26 warning Avoid calling expressions in templates @angular-eslint/template/no-call-expression
17:26 warning Avoid calling expressions in templates @angular-eslint/template/no-call-expression
/Users/mdilyan/Projects/versatile-data-kit/projects/frontend/data-pipelines/gui/projects/data-pipelines/src/lib/components/data-job/pages/executions/data-job-executions-page/data-job-executions-page.component.ts
6:21 warning 'OnInit' is defined but never used @typescript-eslint/no-unused-vars
184:21 warning Avoid referencing unbound methods which may cause unintentional scoping of `this`.
If your function does not access `this`, you can annotate it with `this: void`, or consider using an arrow function instead @typescript-eslint/unbound-method
213:14 warning Lifecycle interface 'OnInit' should be implemented for method 'ngOnInit'. (https://angular.io/styleguide#style-09-01) @angular-eslint/use-lifecycle-interface
251:25 warning Avoid referencing unbound methods which may cause unintentional scoping of `this`.
If your function does not access `this`, you can annotate it with `this: void`, or consider using an arrow function instead @typescript-eslint/unbound-method
/Users/mdilyan/Projects/versatile-data-kit/projects/frontend/data-pipelines/gui/projects/data-pipelines/src/lib/components/data-jobs-manage/components/grid/data-jobs-manage-grid.component.ts
11:30 warning '/Users/mdilyan/Projects/versatile-data-kit/projects/frontend/data-pipelines/gui/node_modules/@versatiledatakit/shared/fesm2015/versatiledatakit-shared.mjs' imported multiple times import/no-duplicates
19:8 warning '/Users/mdilyan/Projects/versatile-data-kit/projects/frontend/data-pipelines/gui/node_modules/@versatiledatakit/shared/fesm2015/versatiledatakit-shared.mjs' imported multiple times import/no-duplicates
/Users/mdilyan/Projects/versatile-data-kit/projects/frontend/data-pipelines/gui/projects/data-pipelines/src/lib/components/widgets/widget-execution-status-gauge/widget-execution-status-gauge.component.html
27:32 warning Avoid calling expressions in templates @angular-eslint/template/no-call-expression
/Users/mdilyan/Projects/versatile-data-kit/projects/frontend/data-pipelines/gui/projects/data-pipelines/src/lib/data-pipelines.module.ts
26:37 warning '/Users/mdilyan/Projects/versatile-data-kit/projects/frontend/data-pipelines/gui/node_modules/@versatiledatakit/shared/fesm2015/versatiledatakit-shared.mjs' imported multiple times import/no-duplicates
31:8 warning '/Users/mdilyan/Projects/versatile-data-kit/projects/frontend/data-pipelines/gui/node_modules/@versatiledatakit/shared/fesm2015/versatiledatakit-shared.mjs' imported multiple times import/no-duplicates
184:45 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any
/Users/mdilyan/Projects/versatile-data-kit/projects/frontend/data-pipelines/gui/projects/data-pipelines/src/lib/model/toast-definitions.model.ts
6:30 warning '/Users/mdilyan/Projects/versatile-data-kit/projects/frontend/data-pipelines/gui/node_modules/@versatiledatakit/shared/fesm2015/versatiledatakit-shared.mjs' imported multiple times import/no-duplicates
8:23 warning '/Users/mdilyan/Projects/versatile-data-kit/projects/frontend/data-pipelines/gui/node_modules/@versatiledatakit/shared/fesm2015/versatiledatakit-shared.mjs' imported multiple times import/no-duplicates
/Users/mdilyan/Projects/versatile-data-kit/projects/frontend/data-pipelines/gui/projects/data-pipelines/src/lib/shared/utils/data-job.util.ts
47:37 warning Avoid referencing unbound methods which may cause unintentional scoping of `this`.
If your function does not access `this`, you can annotate it with `this: void`, or consider using an arrow function instead @typescript-eslint/unbound-method
Signed-off-by: Dilyan Marinov <[email protected]>
DeltaMichael
force-pushed
the
person/mdilyan/fe-lint-and-sa
branch
from
b77e992
to
7d191a7
Compare
gorankokin
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following npm lint warnings
How this was tested
Signed-off-by: Dilyan Marinov [email protected]