fix: esa_enabled for r/vcf_instance #203
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Pull Request
Support for configuring vSAN in ESA mode was added in VCF 5.
It was implemented as an optional attribute with #190
The flaw in my original PR is that the new property is optional and since it is marked with "omitempty" it is skipped during serialization whenever it is set to false.
I've made a change to the SDK that marks the property as required. The containing structure is still optional.
This means that
esa_enabled
will now behave as follows:esa_enabled = true
theVSANEsaConfig
structure will be set and vSAN will be configured in ESA modeesa_enabled = false
theVSANEsaConfig
structure will be set and vSAN will be configured in normal modeesa_enabled
is not set theVSANEsaConfig
structure will be set and vSAN will be configured in normal modeThis will ensure that
Type of Pull Request
Please describe:
Related to Existing Issues
Closes #217
Test and Documentation Coverage
Ran TestAccResourceVcfSddcBasic by modifying the configuration for the 3 scenarios listed above - esa_enabled set to true, false and to nothing.
For bug fixes or features:
Breaking Changes?