Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: esa_enabled for r/vcf_instance #203

Merged
merged 1 commit into from
Jul 25, 2024
Merged

fix: esa_enabled for r/vcf_instance #203

merged 1 commit into from
Jul 25, 2024

Conversation

spacegospod
Copy link
Contributor

@spacegospod spacegospod commented Jul 25, 2024

Summary of Pull Request

Support for configuring vSAN in ESA mode was added in VCF 5.
It was implemented as an optional attribute with #190

The flaw in my original PR is that the new property is optional and since it is marked with "omitempty" it is skipped during serialization whenever it is set to false.

I've made a change to the SDK that marks the property as required. The containing structure is still optional.

This means that esa_enabled will now behave as follows:

  • When esa_enabled = true the VSANEsaConfig structure will be set and vSAN will be configured in ESA mode
  • When esa_enabled = false the VSANEsaConfig structure will be set and vSAN will be configured in normal mode
  • When esa_enabled is not set the VSANEsaConfig structure will be set and vSAN will be configured in normal mode

This will ensure that

  1. ESA is optonal
  2. The default mode is non-ESA

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #217

Test and Documentation Coverage

Ran TestAccResourceVcfSddcBasic by modifying the configuration for the 3 scenarios listed above - esa_enabled set to true, false and to nothing.

For bug fixes or features:

  • Tests have been completed.
  • Documentation has been added/updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Signed-off-by: Stoyan Zhelyazkov <[email protected]>
@spacegospod spacegospod self-assigned this Jul 25, 2024
@github-actions github-actions bot added dependencies Dependencies chore Chore needs-review Needs Review provider Provider labels Jul 25, 2024
@spacegospod spacegospod merged commit 413c7e4 into main Jul 25, 2024
7 checks passed
@tenthirtyam tenthirtyam deleted the bugfix/vsan-esa branch August 8, 2024 01:40
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Aug 8, 2024
@tenthirtyam tenthirtyam added this to the v0.11.0 milestone Aug 22, 2024
@github-actions github-actions bot added the needs-review Needs Review label Aug 22, 2024
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Aug 22, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2024
@tenthirtyam tenthirtyam added bug Bug and removed dependencies Dependencies chore Chore labels Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug provider Provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

esa_enabled is not being treated as optional.
3 participants