Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esa_enabled is not being treated as optional. #217

Closed
4 tasks done
pradeep17j opened this issue Aug 15, 2024 · 3 comments · Fixed by #203
Closed
4 tasks done

esa_enabled is not being treated as optional. #217

pradeep17j opened this issue Aug 15, 2024 · 3 comments · Fixed by #203
Assignees
Labels
bug Bug
Milestone

Comments

@pradeep17j
Copy link

pradeep17j commented Aug 15, 2024

Code of Conduct

  • I have read and agree to the Code of Conduct.
  • Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
  • Do not leave "+1" or other comments that do not add relevant information or questions.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Terraform

v1.7.2

Terraform Provider

v0.10.0

VMware Cloud Foundation

5.2

Description

When esa_enabled property is not specified, the validation fails during apply.

### [root@template vcf_bringup]# terraform apply

**

│ Error: JSON Spec Validation

│   with vcf_instance.sddc_instance,
│   on main.tf line 4, in resource "vcf_instance" "sddc_instance":
│    4: resource "vcf_instance" "sddc_instance" {

│ Invalid vSAN ESA config provided: vSAN ESA config flag cannot be set to empty

**

Affected Resources or Data Sources

resource/vcf_instance

Terraform Configuration

vsan section without esa_enabled


      + vsan {
          + datastore_name = "sddc_mgmt_vsan"
          + license        = (sensitive value)
        }
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

vcf_instance.sddc_instance: Creating...
vcf_instance.sddc_instance: Still creating... [10s elapsed]
vcf_instance.sddc_instance: Still creating... [20s elapsed]
╷
│ Error: JSON Spec Validation
│
│   with vcf_instance.sddc_instance,
│   on main.tf line 4, in resource "vcf_instance" "sddc_instance":
│    4: resource "vcf_instance" "sddc_instance" {
│
│ Invalid vSAN ESA config provided: vSAN ESA config flag cannot be set to empty
│

vsan section with esa_enabled="false" fails at apply

      + vsan {
          + datastore_name = "sddc_mgmt_vsan"
          + esa_enabled    = false
          + license        = (sensitive value)
        }
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

vcf_instance.sddc_instance: Creating...
vcf_instance.sddc_instance: Still creating... [10s elapsed]
vcf_instance.sddc_instance: Still creating... [20s elapsed]

│ Error: JSON Spec Validation

│   with vcf_instance.sddc_instance,
│   on main.tf line 4, in resource "vcf_instance" "sddc_instance":
│    4: resource "vcf_instance" "sddc_instance" {

│ Invalid vSAN ESA config provided: vSAN ESA config flag cannot be set to empty

Debug Output

      + vsan {
          + datastore_name = "sddc_mgmt_vsan"
          + license        = (sensitive value)
        }
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

vcf_instance.sddc_instance: Creating...
vcf_instance.sddc_instance: Still creating... [10s elapsed]
vcf_instance.sddc_instance: Still creating... [20s elapsed]

│ Error: JSON Spec Validation

│   with vcf_instance.sddc_instance,
│   on main.tf line 4, in resource "vcf_instance" "sddc_instance":
│    4: resource "vcf_instance" "sddc_instance" {

│ Invalid vSAN ESA config provided: vSAN ESA config flag cannot be set to empty

Panic Output

No response

Expected Behavior

Successful Bringup

Actual Behavior

Fails at validation

Steps to Reproduce

terraform apply

Environment Details

No response

Screenshots

No response

References

No response

@pradeep17j pradeep17j added bug Bug needs-triage Needs Triage labels Aug 15, 2024
@github-actions github-actions bot added the pending-review Pending Review label Aug 15, 2024
@tenthirtyam tenthirtyam removed the pending-review Pending Review label Aug 15, 2024
@tenthirtyam tenthirtyam added this to the v0.11.0 milestone Aug 15, 2024
@tenthirtyam
Copy link
Collaborator

@spacegospod - this was resolved in #203, right?

@tenthirtyam tenthirtyam removed the needs-triage Needs Triage label Aug 22, 2024
@spacegospod
Copy link
Contributor

@tenthirtyam correct, this is fixed and is set to go out with the next release

Copy link

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants