Add support for DNS settings in NSX-T backed external networks #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Didainius
requested review from
lvirbalas,
adambarreiro and
dataclouder
as code owners
dataclouder
reviewed
Jan 17, 2023
Signed-off-by: Dainius Serplis <[email protected]>
dataclouder
approved these changes
Jan 17, 2023
Signed-off-by: Dainius Serplis <[email protected]>
lvirbalas
reviewed
Jan 19, 2023
Signed-off-by: Dainius Serplis <[email protected]>
lvirbalas
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #964
External network V2 resource can handle NSX-V and NSX-T based external networks (using the same API), however, DNS fields (dns1, dns2, dns_suffix) were only available for NSX-V based networks in UI. We also had a Terraform schema validation to prevent setting these fields for NSX-T networks.
Apparently, there are some use cases for having these fields set for NSX-T networks as well (DNS settings can be inherited for direct networks).
This PR - improves tests to test these fields and also removes schema validation. It turns out that the
dns_suffixcan be set, but is never returned by API which is a VCD bug. It should be fixed in future versions, but that test part remains commented for now as it doesn't work up to VCD 10.4.1.