-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add provider_type OAUTH to vdc_org_group #1013
Conversation
* add 'OAUTH' to list of valid input for attribute 'provider_type' at resource 'vcd_org_group' * change description of datasource and resource 'vcd_org_group' * update docs Signed-off-by: steadyjaw <[email protected]>
@steadyjaw, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
1 similar comment
@steadyjaw, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
@steadyjaw, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
1 similar comment
@steadyjaw, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: steadyjaw <[email protected]>
b4037df
to
ba91b18
Compare
@steadyjaw , You can have inspiration about the contents from other messages, but I think your PR title is good enough. |
Signed-off-by: steadyjaw <[email protected]>
@Didainius |
Signed-off-by: steadyjaw <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am approving this knowing that there are no tests because they wouldn't be trivial to make (OAUTH provider needed), but this PR only lifts validation of fields so has no risk to break anything else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nitpicks with spaces 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for a clean PR!
Signed-off-by: steadyjaw <[email protected]>
I have removed all "double-spaces". |
Thanks @steadyjaw, this is now in |
Thank you! For your great work and the possbillity to contribute to it. |
fixes #1011
we have organizations using an IdP with oidc and we need to import oauth groups using terrafrom.
Since the changes are trivial, I thought it was a good oppertunity to do them by my self a open a pull request.
Changes made: