Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provider_type OAUTH to vdc_org_group #1013

Merged
merged 5 commits into from
Mar 15, 2023

Conversation

steadyjaw
Copy link
Contributor

fixes #1011
we have organizations using an IdP with oidc and we need to import oauth groups using terrafrom.

Since the changes are trivial, I thought it was a good oppertunity to do them by my self a open a pull request.

Changes made:

  • add 'OAUTH' to list of valid input for attribute 'provider_type' at resource 'vcd_org_group'
  • change description of datasource and resource 'vcd_org_group'
  • update docs

* add 'OAUTH' to list of valid input for attribute 'provider_type' at resource 'vcd_org_group'
* change description of datasource and resource 'vcd_org_group'
* update docs

Signed-off-by: steadyjaw <[email protected]>
@steadyjaw steadyjaw changed the title Add provider_type OAUTH to vdc_org_group (#1011) Add provider_type OAUTH to vdc_org_group Mar 7, 2023
@vmwclabot
Copy link
Member

@steadyjaw, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link
Member

@steadyjaw, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@steadyjaw, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

1 similar comment
@vmwclabot
Copy link
Member

@steadyjaw, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@steadyjaw steadyjaw force-pushed the group-provider-type-oauth branch from b4037df to ba91b18 Compare March 7, 2023 09:59
@Didainius
Copy link
Collaborator

@steadyjaw ,
Thanks for the PR. Could you add a changelog note To do this you should put a file named 1013-improvements.md into .changes/v3.9.0/.

You can have inspiration about the contents from other messages, but I think your PR title is good enough.

@steadyjaw steadyjaw requested a review from adezxc as a code owner March 8, 2023 09:00
@steadyjaw
Copy link
Contributor Author

@Didainius
Thanks for you message.
I just have added the change to the list of improvements.

Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this knowing that there are no tests because they wouldn't be trivial to make (OAUTH provider needed), but this PR only lifts validation of fields so has no risk to break anything else.

Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicks with spaces 😄

.changes/v3.9.0/1013-improvements.md Outdated Show resolved Hide resolved
.changes/v3.9.0/984-improvements.md Outdated Show resolved Hide resolved
website/docs/r/org_group.html.markdown Outdated Show resolved Hide resolved
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for a clean PR!

@steadyjaw
Copy link
Contributor Author

I have removed all "double-spaces".
Hope everything is fine now.
Looking forward using this new feature. :)

@Didainius Didainius merged commit 31ea32a into vmware:main Mar 15, 2023
@Didainius
Copy link
Collaborator

Thanks @steadyjaw, this is now in main and will be part of 3.9.0 release

@steadyjaw
Copy link
Contributor Author

Thank you! For your great work and the possbillity to contribute to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR - please add "OAUTH" as provider_type of vcd_org_group resources
7 participants