-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update Publish-*
methods for JSON generation
#79
feat: update Publish-*
methods for JSON generation
#79
Conversation
Signed-off-by: bhumitra nagar <[email protected]>
Publish-*
methods for JSON generation
Hi @bhumitra - I’ve marked the pull request for the Ryan Johnson |
Update: I will review it soon now that v1.0.6 is now released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes requestion on first pass:
- Other examples and the README.md use
F:\Reporting
vsF:\Reports
. Added suggestions to keep them consistent. - Use
-Depth
vs-depth
. - Minor grammatical suggestions.
Signed-off-by: bhumitra nagar <[email protected]> Co-authored-by: Ryan Johnson <[email protected]>
Thanks for committing the review suggestions. I’ll give in a flurry of tests tomorrow and report back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Signed-off-by: Ryan Johnson <[email protected]>
2bf47c9
to
0d62d83
Compare
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.
Summary of Pull Request
Updated
Publish-*
cmdlets to support JSON generation for:Publish-BackupStatus
Publish-NsxtTransportNodeStatus
Publish-NsxtTier0BgpStatus
Publish-SnapshotStatus
Publish-LocalUserExpiry
Publish-StorageCapacityHealth
Added 2 additional functions:
Publish-NsxtHealthNonSOS
Publish-ComponentConnectivityHealthNonSOS
Signed-off-by: bhumitra nagar [email protected]
Type of Pull Request
Please describe:
Related to Existing Issues
Closes #37
Test and Documentation Coverage
Breaking Changes?
New if/else path has been added to these cmdlets. if called using
-jsonOutput,
then JSON is generated. Else, the functionality is the same as before. I have tested the functionality and it works fine.