Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Publish-* cmdlets to support json generation #77

Closed
wants to merge 8 commits into from

Conversation

bhumitra
Copy link
Contributor

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request
Updated Publish-* cmdlets to support json generation for -
Publish-BackupStatus
Publish-NsxtTransportNodeStatus
Publish-NsxtTier0BgpStatus
Publish-SnapshotStatus
Publish-LocalUserExpiry
Publish-StorageCapacityHealth

Added 2 new methods -
Publish-NsxtHealthNonSOS
Publish-ComponentConnectivityHealthNonSOS

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

#37
Issue Number: 37

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

New if/else path has been added to these cmdlets. if called using -jsonOutput, then json is generated. Else, the functionality is the same as before. I have tested the functionality and it works fine.

@bhumitra bhumitra requested a review from a team as a code owner January 25, 2023 16:59
@vmwclabot
Copy link
Member

@bhumitra, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Jan 25, 2023
@github-actions github-actions bot added the needs-review Needs Review label Jan 25, 2023
@tenthirtyam
Copy link
Collaborator

Closing in favor of #79.

@tenthirtyam tenthirtyam removed the needs-review Needs Review label Jan 31, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
@bhumitra bhumitra deleted the dev-bn-issue-37 branch March 17, 2023 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dco-required DCO Required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants