Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hardware compatibility checks #129

Merged
merged 4 commits into from
Apr 25, 2023
Merged

feat: add hardware compatibility checks #129

merged 4 commits into from
Apr 25, 2023

Conversation

tenthirtyam
Copy link
Collaborator

@tenthirtyam tenthirtyam commented Apr 18, 2023

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

  • Added Publish-HardwareCompatibilityHealth to return the hardware compatibility health from the SoS Health Summary JSON data.
  • Updated Invoke-VcfHealthReport to include the hardware compatibility health using the Publish-HardwareCompatibilityHealth cmdlet.
  • Updates CHANGELOG.md.
  • Updates module version from v2.0.0.1013 to v2.1.0.1001.
  • Updates module GUID for v2.1.0.xxxx.
  • Updates module generated date based on planned release date.

Signed-off-by: Ryan Johnson [email protected]

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #97

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).
PS F:\> Publish-HardwareCompatibilityHealth -json F:\Reporting\HealthReports\sfo-vcf01-all-health-results.json

Component Resource     Alert   Message
--------- --------     -----   -------
Cluster   sfo-m01-cl01 GREEN   Controller driver is VMware certified is successful
Cluster   sfo-m01-cl01 GREEN   Controller is VMware certified for ESXi release is successful
Cluster   sfo-m01-cl01 SKIPPED Controller firmware is VMware certified is successful
Cluster   sfo-m01-cl01 GREEN   vSAN firmware version recommendation is successful
Cluster   sfo-m01-cl01 GREEN   Controller disk group mode is VMware certified is successful
Cluster   sfo-m01-cl01 GREEN   vSAN HCL DB Auto Update is successful
Cluster   sfo-m01-cl01 SKIPPED vSAN HCL DB up-to-date have failed
Cluster   sfo-m01-cl01 SKIPPED SCSI controller is VMware certified is successful
Cluster   sfo-m01-cl01 GREEN   NVMe device is VMware certified is successful
Cluster   sfo-m01-cl01 GREEN   NVMe device can be identified is successful
Cluster   sfo-w01-cl01 GREEN   Controller driver is VMware certified is successful
Cluster   sfo-w01-cl01 GREEN   Controller is VMware certified for ESXi release is successful
Cluster   sfo-w01-cl01 SKIPPED Controller firmware is VMware certified is successful
Cluster   sfo-w01-cl01 GREEN   vSAN firmware version recommendation is successful
Cluster   sfo-w01-cl01 GREEN   Controller disk group mode is VMware certified is successful
Cluster   sfo-w01-cl01 GREEN   vSAN HCL DB Auto Update is successful
Cluster   sfo-w01-cl01 SKIPPED vSAN HCL DB up-to-date have failed
Cluster   sfo-w01-cl01 SKIPPED SCSI controller is VMware certified is successful
Cluster   sfo-w01-cl01 GREEN   NVMe device is VMware certified is successful
Cluster   sfo-w01-cl01 GREEN   NVMe device can be identified is successful

image

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

- Added `Publish-HardwareCompatibilityHealth` to return the hardware compatibilty health from the SoS Health Summary JSON data.
- Updated` Invoke-VcfHealthReport` to include the hardware compatibility health using the `Publish-HardwareCompatibilityHealth` cmdlet.

Ref: #97

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam added enhancement Enhancement report/health Health Report labels Apr 18, 2023
@tenthirtyam tenthirtyam self-assigned this Apr 18, 2023
@tenthirtyam tenthirtyam added this to the v2.1.0 milestone Apr 18, 2023
@tenthirtyam
Copy link
Collaborator Author

Note
Holding for v2.1.0 since v2.0.0 is code complete.

@tenthirtyam tenthirtyam added do-not-merge Do Not Merge and removed do-not-merge Do Not Merge labels Apr 20, 2023
Ryan Johnson added 2 commits April 25, 2023 09:01
@vmwclabot vmwclabot added the dco-required DCO Required label Apr 25, 2023
- Updates module version from v2.0.0.1013 to v2.1.0.1001.
- Updates module GUID for v2.1.0.xxxx.
- Updates module generated date based on planned release date.

Signed-off-by: Ryan Johnson <[email protected]>
@vmware vmware deleted a comment from vmwclabot Apr 25, 2023
@vmware vmware deleted a comment from vmwclabot Apr 25, 2023
@tenthirtyam tenthirtyam removed the dco-required DCO Required label Apr 25, 2023
@tenthirtyam tenthirtyam marked this pull request as ready for review April 25, 2023 13:18
@tenthirtyam tenthirtyam requested a review from a team as a code owner April 25, 2023 13:18
@tenthirtyam tenthirtyam requested a review from GaryJBlake April 25, 2023 13:18
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GaryJBlake GaryJBlake merged commit c609544 into main Apr 25, 2023
@GaryJBlake GaryJBlake deleted the feat/add-hardware branch April 25, 2023 13:57
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement report/health Health Report
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for hardware compatibility health checks
3 participants