refactor: remove sddcManagerRootPass from Invoke-VcfHealthReport
#110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenthirtyam
added
size/s
Removes the `sddcManagerRootPass` parameter from `Invoke-VcfHealthReport` cmdlet as it uses the refactored `Request-SoSHealthJson` cmdlet. Signed-off-by: Ryan Johnson <[email protected]>
tenthirtyam
force-pushed
the
refactor/remove-sddcmanagerrootpass
branch
from
66fa121 to
51e5810
Compare
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
=In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.
Summary of Pull Request
Removes the
sddcManagerRootPassparameter fromInvoke-VcfHealthReportcmdlet as it uses the refactoredRequest-SoSHealthJsoncmdlet.Type of Pull Request
Please describe:
Related to Existing Issues
Issue Number: #102, #90
Test and Documentation Coverage
Breaking Changes?
Breaks the use of
Publish-LocalUserExpirywhen running the health report. This will be resolved in #90 which must be completed for v2.0.0 to usePublish-PasswordHealth.