refactor: update Request-SoSHealthJson to use the api

[garlicNova]

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Transition SoS Health to /v1/system/health-summary API.

Signed-off-by: Kevin Teng [email protected]

Type of Pull Request

• This is a bug fix.
• This is an enhancement or feature.
• This is a code style / formatting update.
• This is a documentation update.
• This is a refactoring update.
• This is a chore update
• This is something else.
  Please describe:

Related to Existing Issues

Closes #96

Test and Documentation Coverage

• Tests have been completed (for bug fixes / features).
• Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

• Yes, there are breaking changes.
• No, there are no breaking changes.

Breaks the use of Publish-LocalUserExpiry when running the health report. This will be resolved in #90 which must be completed for v2.0.0 to use Publish-PasswordHealth.

[GaryJBlake]

Is there a reason why we have not used PowerVCF for the API calls for SoS?

[tenthirtyam]

Is there a reason why we have not used PowerVCF for the API calls for SoS?

Great point, Gary!

[garlicNova]

Is there a reason why we have not used PowerVCF for the API calls for SoS?

I will look into it.

[vmwclabot]

@garlicNova, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 8f18bd5 must be signed by [email protected]

[vmwclabot]

@garlicNova, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit af36fbc must be signed by [email protected]

[tenthirtyam]

Error observered on VMware Photon OS with PowerShell Core:

PS /home/vmware/code/VMware.CloudFoundation.Reporting> Import-Module ./VMware.CloudFoundation.Reporting.psm1                                                 PS /home/vmware/code/VMware.CloudFoundation.Reporting> Request-SoSHealthJson -server sfo-vcf01.sfo.rainpole.io -user admin@local -pass VMw@re1!VMw@re1! -reportPath /home/vmware/reports -workloadDomain sfo-w01
tar (child): /home/vmware/reports\\1I1K3C\\health-summary.tar.gz: Cannot open: No such file or directory             ]
tar (child): Error is not recoverable: exiting now
/usr/bin/tar: Child returned status 2
Copy-Item: Cannot find path '/health-results.json' because it does not exist.

Get-Content: Cannot find path '/home/vmware/reports/sfo-w01-all-health-results.json' because it does not exist.

/home/vmware/reports/sfo-w01-all-health-results.json

[garlicNova]

Error observered on VMware Photon OS with PowerShell Core:

PS /home/vmware/code/VMware.CloudFoundation.Reporting> Import-Module ./VMware.CloudFoundation.Reporting.psm1                                                 PS /home/vmware/code/VMware.CloudFoundation.Reporting> Request-SoSHealthJson -server sfo-vcf01.sfo.rainpole.io -user admin@local -pass VMw@re1!VMw@re1! -reportPath /home/vmware/reports -workloadDomain sfo-w01
tar (child): /home/vmware/reports\\1I1K3C\\health-summary.tar.gz: Cannot open: No such file or directory             ]
tar (child): Error is not recoverable: exiting now
/usr/bin/tar: Child returned status 2
Copy-Item: Cannot find path '/health-results.json' because it does not exist.

Get-Content: Cannot find path '/home/vmware/reports/sfo-w01-all-health-results.json' because it does not exist.

/home/vmware/reports/sfo-w01-all-health-results.json

fixed, change hardcode path "backward slash" to use powershell cmdlets Join-Path to resolve issues between windows and linux. (backward slash vs forward slash)

Ready for next review.

[tenthirtyam]

• Updated the module version, GUID, and description in 97c698f.
• Updates the CHANGELOG.md in 27d6c8d.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.