Sort packages by version instead of relying on ChartVersions[0]
#6588
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
As described in #6584, we were returning wrong versions in some corner cases (mainly using pre-releases). It seems we were relying on
ChartVersions[0]
with the explicit assumption that it would always contain the latest version. However, this is not the case. Since the DB does not know about semver (unless we used some extensions), the ORDER BY query might be wrong.This PR is replacing the occurrences of
ChartVersions[0]
in favor of a previous semver sorting. The affected operations are:GetAvailablePackageDetail
,GetAvailablePackageSummaries
,GetInstalledPackageSummaries
andGetInstalledPackageDetail
.Benefits
The
latestVersion
returned by the API (and therefore used by the UI -as is-, we don't sort them in client-side) will be the one that has to be.Possible drawbacks
Applicable issues
Additional information
Example of a new version being properly detected: