GetAvailablePackageVersions returns non-semver versions unchanged #6249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Nelson <[email protected]>
✅ Deploy Preview for kubeapps-dev canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
When Kubeapps was encountering Helm charts with non-semver versions, rather than just returning the versions as they are, we were implicitly converting them to the closest semver. This resulted in Kubeapps then not being able to upgrade to a different version once an app with a non-semver version was installed.
See #6099 for more detail.
Benefits
If people choose to use non-semver versions, we don't block them from upgrading.
Possible drawbacks
We were previously ignoring errors when creating semver versions whereas with this PR we now simply return all the versions as they were provided. This may change some untested behavior, though unlikely.
Applicable issues
Additional information
Also fixes an accidental change to our dev environment Makefile (I'd accidentally committed a change in #6209 that had our dev environment installing the upstream bitnami chart rather than the dev kubeapps one).