-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Parse the yaml before dumping it back to string #5893
Conversation
Signed-off-by: Vaibhav Mittal <[email protected]>
…s-fix Parse the yaml before dumping it back to string
@mittalvaibhav1, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
@mittalvaibhav1, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
@mittalvaibhav1, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:
|
@mittalvaibhav1, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as CI is happy, +1... thanks again for jumping in with the report and fix.
@mittalvaibhav1, VMware has approved your signed contributor license agreement. |
Good to go :) |
Woo! |
Just want to double-check: @antgamdia : I'm assuming there wasn't a reason you didn't use |
From memory, I can't recall why I didn't use it; I mean, when performing IRL tests we should have noticed it, but we didn't. So, either I actually missed it (most likely, I guess 😆 ) or the latest changes on the custom values have had a sort of side effect here. |
Signed-off-by: Vaibhav Mittal [email protected]
Description of the change
Fix the incorrect formatting of the installation values on the Kubeapps UI
Benefits
Possible drawbacks
Applicable issues
Additional information