Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Parse the yaml before dumping it back to string #5893

Merged
merged 2 commits into from
Jan 22, 2023

Conversation

mittalvaibhav1
Copy link
Contributor

@mittalvaibhav1 mittalvaibhav1 commented Jan 19, 2023

Signed-off-by: Vaibhav Mittal [email protected]

Description of the change

Fix the incorrect formatting of the installation values on the Kubeapps UI

Benefits

  • Cleaner UI 😀

Possible drawbacks

  • None as far as ik

Applicable issues

Additional information

@vmwclabot
Copy link

@mittalvaibhav1, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@netlify
Copy link

netlify bot commented Jan 19, 2023

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 7824f12
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/63c9298fb104d400084625b6

@vmwclabot
Copy link

@mittalvaibhav1, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@vmwclabot
Copy link

@mittalvaibhav1, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

Please provide full street address

@vmwclabot
Copy link

@mittalvaibhav1, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as CI is happy, +1... thanks again for jumping in with the report and fix.

@vmwclabot
Copy link

@mittalvaibhav1, VMware has approved your signed contributor license agreement.

@mittalvaibhav1
Copy link
Contributor Author

Good to go :)

@absoludity
Copy link
Contributor

Woo!

@absoludity absoludity merged commit 4407dda into vmware-tanzu:main Jan 22, 2023
@absoludity
Copy link
Contributor

Just want to double-check: @antgamdia : I'm assuming there wasn't a reason you didn't use parseToJS here was there? (I'm 99% sure you would have left a comment if that were the case, so it's probably just something that was missed, but want to be sure).

@antgamdia
Copy link
Contributor

if that were the case, so it's probably just something that was missed, but want to be sure).

From memory, I can't recall why I didn't use it; I mean, when performing IRL tests we should have noticed it, but we didn't. So, either I actually missed it (most likely, I guess 😆 ) or the latest changes on the custom values have had a sort of side effect here.
Anyway, let's keep an eye on the whole process of displaying/editing values just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Installation values formatted incorrectly
4 participants