Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Installation values formatted incorrectly #5894

Closed
mittalvaibhav1 opened this issue Jan 19, 2023 · 2 comments · Fixed by #5893
Closed

[Bug] Installation values formatted incorrectly #5894

mittalvaibhav1 opened this issue Jan 19, 2023 · 2 comments · Fixed by #5893
Labels
kind/bug An issue that reports a defect in an existing feature

Comments

@mittalvaibhav1
Copy link
Contributor

Describe the bug
The installation values are not properly formatted in the yaml format in the installation values section

To Reproduce
Steps to reproduce the behavior:

  1. Go to Kubeapps UI and open the details page of any release
  2. Scroll down to Installation Values
  3. See error

Expected behavior
The installation values should be properly formatted in yaml format

Screenshots
If applicable, add screenshots to help explain your problem.
Before
Before

Created a PR for resolution #5893

After
After

Desktop (please complete the following information):

  • Version 2.6.2
  • Kubernetes version 1.24.3
  • Package version default in kubeapps helm chart

Additional context
Add any other context about the problem here.
@mittalvaibhav1 mittalvaibhav1 added the kind/bug An issue that reports a defect in an existing feature label Jan 19, 2023
@mittalvaibhav1 mittalvaibhav1 mentioned this issue Jan 19, 2023
Merged
@absoludity
Copy link
Contributor

Thanks for the report and fix @mittalvaibhav1 :) I've just re-run the failing e2e tests... I'll investigate them if it's a persistent issue.

@antgamdia
Copy link
Contributor

(...) 'll investigate them if it's a persistent issue.

Yep, yesterday GitHub reported an incident in the actions and other components: https://www.githubstatus.com/incidents/n18j5g7wpg0s

absoludity pushed a commit that referenced this issue Jan 22, 2023
@mittalvaibhav1
[Bug] Parse the yaml before dumping it back to string (#5893)
4407dda 
Signed-off-by: Vaibhav Mittal
<[email protected]>

<!--
Before you open the request please review the following guidelines and
tips to help it be more easily integrated:

 - Describe the scope of your change - i.e. what the change does.
 - Describe any known limitations with your change.
- Please run any tests or examples that can exercise your modified code.

 Thank you for contributing!
 -->

### Description of the change
Fix the incorrect formatting of the installation values on the Kubeapps
UI
<!-- Describe the scope of your change - i.e. what the change does. -->

### Benefits
- Cleaner UI 😀 
<!-- What benefits will be realized by the code change? -->

### Possible drawbacks
- None as far as ik
<!-- Describe any known limitations with your change -->

### Applicable issues

<!-- Enter any applicable Issues here (You can reference an issue using
#) -->

- fixes #5894 

### Additional information

<!-- If there's anything else that's important and relevant to your pull
request, mention that information here.-->

Signed-off-by: Vaibhav Mittal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug An issue that reports a defect in an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Bug] Parse the yaml before dumping it back to string mittalvaibhav1/kubeapps
3 participants
@absoludity @antgamdia @mittalvaibhav1