Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[torch.compile] Adding torch compile annotations to some models #9876

Merged
merged 4 commits into from
Nov 1, 2024
Merged

[torch.compile] Adding torch compile annotations to some models #9876

merged 4 commits into from
Nov 1, 2024

Conversation

CRZbulabula
Copy link
Contributor

This PR is to improve #9589, adding torch compile annotations to some models and testing them.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@youkaichao youkaichao self-requested a review as a code owner November 1, 2024 06:46
@youkaichao
revert one
fc16b10 
Signed-off-by: youkaichao <[email protected]>
@mergify mergify bot added the documentation Improvements or additions to documentation label Nov 1, 2024
youkaichao
youkaichao reviewed Nov 1, 2024
View reviewed changes
vllm/model_executor/models/qwen2_moe.py
@@ -312,6 +313,7 @@ def forward(
return hidden_states, residual


@support_torch_compile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will actually cause on error, but let me merge it first, so that pytorch team can easily reproduce it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the error is:

RuntimeError: aten/src/ATen/RegisterCUDA.cpp:7275: SymIntArrayRef expected to contain only concrete integers

youkaichao
youkaichao approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the great work!

@youkaichao youkaichao merged commit 2b5bf20 into vllm-project:main Nov 1, 2024
27 of 31 checks passed
@CRZbulabula CRZbulabula deleted the torch-compile-addtional-test branch November 1, 2024 11:06
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
@CRZbulabula @youkaichao
[torch.compile] Adding torch compile annotations to some models (vllm…
4b6f35d 
…-project#9876)

Signed-off-by: youkaichao <[email protected]>
Co-authored-by: youkaichao <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
@CRZbulabula @youkaichao
[torch.compile] Adding torch compile annotations to some models (vllm…
9579182 
…-project#9876)

Signed-off-by: youkaichao <[email protected]>
Co-authored-by: youkaichao <[email protected]>
Signed-off-by: Linkun Chen <[email protected]>
richardsliu pushed a commit to richardsliu/vllm that referenced this pull request Nov 4, 2024
@CRZbulabula @youkaichao @richardsliu
[torch.compile] Adding torch compile annotations to some models (vllm…
92b845d 
…-project#9876)

Signed-off-by: youkaichao <[email protected]>
Co-authored-by: youkaichao <[email protected]>
Signed-off-by: Richard Liu <[email protected]>
bigPYJ1151 pushed a commit to bigPYJ1151/vllm that referenced this pull request Nov 5, 2024
@CRZbulabula @youkaichao @bigPYJ1151
[torch.compile] Adding torch compile annotations to some models (vllm…
2b06273 
…-project#9876)

Signed-off-by: youkaichao <[email protected]>
Co-authored-by: youkaichao <[email protected]>
hissu-hyvarinen pushed a commit to ROCm/vllm that referenced this pull request Nov 6, 2024
@CRZbulabula @youkaichao @hissu-hyvarinen
[torch.compile] Adding torch compile annotations to some models (vllm…
d189273 
…-project#9876)

Signed-off-by: youkaichao <[email protected]>
Co-authored-by: youkaichao <[email protected]>
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
@CRZbulabula @youkaichao @JC1DA
[torch.compile] Adding torch compile annotations to some models (vllm…
ba16c99 
…-project#9876)

Signed-off-by: youkaichao <[email protected]>
Co-authored-by: youkaichao <[email protected]>
Signed-off-by: Loc Huynh <[email protected]>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@CRZbulabula @youkaichao @sumitd2
[torch.compile] Adding torch compile annotations to some models (vllm…
50d1009 
…-project#9876)

Signed-off-by: youkaichao <[email protected]>
Co-authored-by: youkaichao <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
@CRZbulabula @youkaichao
[torch.compile] Adding torch compile annotations to some models (vllm…
f4cdc86 
…-project#9876)

Signed-off-by: youkaichao <[email protected]>
Co-authored-by: youkaichao <[email protected]>
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
@CRZbulabula @youkaichao @mfournioux
[torch.compile] Adding torch compile annotations to some models (vllm…
c3eaa96 
…-project#9876)

Signed-off-by: youkaichao <[email protected]>
Co-authored-by: youkaichao <[email protected]>
Signed-off-by: Maxime Fournioux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youkaichao youkaichao youkaichao approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CRZbulabula @youkaichao