[torch.compile] auto infer dynamic_arg_dims from type annotation #9589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
ProExpertProg
approved these changes
Oct 22, 2024
vllm/compilation/decorators.py
Outdated
| `Optional[torch.Tensor]`, the first dimension will be | ||
| marked as dynamic. | ||
| - if the argument is annotated as `IntermediateTensors`, all the tensors | ||
| in the intermediate tensors will be marked as dynamic. |
There was a problem hiding this comment.
Does this refer to all dimensions of the intermediate tensors or just the first one? Could you clarify the comment?
bnellnm
approved these changes
Oct 22, 2024
charlifu
pushed a commit
to charlifu/vllm
that referenced
this pull request
Oct 23, 2024
…m-project#9589) Signed-off-by: charlifu <[email protected]>
This was referenced Oct 24, 2024
Alvant
pushed a commit
to compressa-ai/vllm
that referenced
this pull request
Oct 26, 2024
…m-project#9589) Signed-off-by: Alvant <[email protected]>
MErkinSag
pushed a commit
to MErkinSag/vllm
that referenced
this pull request
Oct 26, 2024
…m-project#9589) Signed-off-by: Erkin Sagiroglu <[email protected]>
garg-amit
pushed a commit
to garg-amit/vllm
that referenced
this pull request
Oct 28, 2024
…m-project#9589) Signed-off-by: Amit Garg <[email protected]>
FerdinandZhong
pushed a commit
to FerdinandZhong/vllm
that referenced
this pull request
Oct 29, 2024
…m-project#9589) Signed-off-by: qishuai <[email protected]>
NickLucche
pushed a commit
to NickLucche/vllm
that referenced
this pull request
Oct 31, 2024
…m-project#9589) Signed-off-by: NickLucche <[email protected]>
NickLucche
pushed a commit
to NickLucche/vllm
that referenced
this pull request
Oct 31, 2024
…m-project#9589) Signed-off-by: NickLucche <[email protected]>
sumitd2
pushed a commit
to sumitd2/vllm
that referenced
this pull request
Nov 14, 2024
…m-project#9589) Signed-off-by: Sumit Dubey <[email protected]>
KuntaiDu
pushed a commit
to KuntaiDu/vllm
that referenced
this pull request
Nov 20, 2024
mfournioux
pushed a commit
to mfournioux/vllm
that referenced
this pull request
Nov 20, 2024
…m-project#9589) Signed-off-by: Maxime Fournioux <[email protected]>
tlrmchlsmth
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Nov 23, 2024
…m-project#9589) Signed-off-by: Tyler Michael Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make torch.compile support easier