Repository navigation
Conversation
Signed-off-by: waizuichougou <2082431897@qq.com>
waizuichougou
requested review from
ApostaC,
ivanium,
orozery and
wzhao18
as code owners
November 1, 2026 14:23
Contributor
|
/ci run |
|
✅ @waizuichougou, CI is now available for this PR.
|
|
✅ Triggered Buildkite CI #99183 for commit ℹ️ This PR is 43 commits behind upstream |
orozery
approved these changes
Nov 3, 2026
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Three tests fail on
main:test_partial_tail_store_uses_attention_and_recurrent_cow_sourcesand bothtest_eagle_partial_tail_round_trip_serves_mamba_checkpointcases. After #62613 made Mamba events report the checkpoint block size and predecessor hash, the first test still expected placeholder values. After #63249 changed load-job keys to an ordered tuple, the EAGLE tests still compared that tuple with a set. This PR updates those stale expectations.Claims
Validation
On latest
main(5d55ef1590), the focused run reports3 failed, 464 deselected; with these expectation updates it reports3 passed, 464 deselected. Ruff, formatting, andgit diff --checkpass.Details
The Mamba event tracker emits the checkpoint block size (
4) and links the checkpoint hash to its predecessor; the scheduler test still expected the older placeholder values. A separate EAGLE round-trip assertion compared the load job's ordered key tuple with a set, although the scheduler preserves prefix order. This PR changes test assertions only; it does not change CI configuration or test markers.Duplicate-work check: open PR searches found no change for these stale scheduler assertions. Open PR #63550 adds KV event layout coverage in
tests/v1/core/test_kv_cache_events_layouts.py; it does not modify or cover these offloading scheduler expectations. Open PR #59177 addresses a separate flaky XPU event test.Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Keeps changes within the affected scheduler tests and follows current event and ordering contracts.
Testing and Validation: Reproduces the failures on
mainand passes the focused and full test files.Code Quality and Style: Updates only stale test assertions; no production code or user documentation changes are needed.
Pull Request Contents: Follows the repository template, documents root cause, validation, and duplicate-work checks.