Repository navigation
[CI] Enroll the remaining Misc and Samplers jobs in automatic sharding (17 jobs) - #64596
Merged
khluu merged 1 commit intoOct 30, 2026
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thang Nguyen <thangnguyenvn647@gmail.com>
Contributor
Author
|
/ci run |
|
✅ Triggered Buildkite CI #98461 for commit |
khluu
approved these changes
Oct 30, 2026
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Enrolls the remaining Misc and Samplers jobs in
automatic_shard: 17 jobs (9 steps and 8 AMD mirrors). Part of a series that enrolls every remaining test step, split by test area for review. Commands change only where noted below.Claims
v1-corev1-metrics-lmevalextract-hidden-states-integrationacceptance-length-test-large-modelsmetrics-tracing-2-gpusextract-hidden-states-integration-2-gpusamd-umbp-connector-unit-mi355samplers-testsamplers-multimodal-beam-searchValidation
/ci run(98461) plus a scoped build (98472) for the optional steps and AMD mirrors on this head: every enrolled job passed, and every shard finished under 22 minutes.Details
test_umbp_*.pyfiles instead of the glob, for the same reason.torchrun, examples) are enrolled too; the generator keeps them as one job. Standalone AMD steps plan like any other since Fix automatic sharding for standalone AMD jobs and selected tests ci-infra#871.timeout_in_minutesstays per job. Fallback-aware timeouts belong in a central timeout setting.🤖 Generated with Claude Code
Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.
BEFORE SUBMITTING, PLEASE READ https://docs.vllm.ai/en/latest/contributing (anything written below this line will be removed by GitHub Actions)