Skip to content

[CI] Enroll the remaining Misc and Samplers jobs in automatic sharding (17 jobs) - #64596

Merged
khluu merged 1 commit into
vllm-project:mainfrom
Thangnguyenvn98:agent/automatic-shard-misc-samplers
Oct 30, 2026
Merged

khluu merged 1 commit into
vllm-project:mainfrom
Thangnguyenvn98:agent/automatic-shard-misc-samplers

Conversation

@Thangnguyenvn98

@Thangnguyenvn98 Thangnguyenvn98 commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Overview

Enrolls the remaining Misc and Samplers jobs in automatic_shard: 17 jobs (9 steps and 8 AMD mirrors). Part of a series that enrolls every remaining test step, split by test area for review. Commands change only where noted below.

Claims

Step Plan AMD mirror
v1-core 1 shard 1 shard
v1-metrics-lmeval 1 job (not plain pytest) 1 job (not plain pytest)
extract-hidden-states-integration 1 shard 1 shard
acceptance-length-test-large-models 1 shard 1 shard
metrics-tracing-2-gpus 1 shard 1 shard
extract-hidden-states-integration-2-gpus 1 shard 1 shard
amd-umbp-connector-unit-mi355 1 shard none
samplers-test 1 shard 1 shard
samplers-multimodal-beam-search 1 shard 1 shard
  • One-shard and one-job plans run the same tests as on main, as one job, and split by themselves once their tests grow.

Validation

  • Planned each step and mirror with ci-infra main's planner against main's timings; every plan is within 10% of the same plan run as one job.
  • The sharding harness (each shard's commands run against a mock test tree, as a PR build and as main with the OTel wrapper) shows every test runs exactly once wherever a plan has 2 or more shards.
  • Every step and mirror passes on recent main runs, nightly included.
  • /ci run (98461) plus a scoped build (98472) for the optional steps and AMD mirrors on this head: every enrolled job passed, and every shard finished under 22 minutes.

Details

  • UMBP Connector Unit Tests names its five test_umbp_*.py files instead of the glob, for the same reason.
  • Not plain pytest steps (shell scripts, torchrun, examples) are enrolled too; the generator keeps them as one job. Standalone AMD steps plan like any other since Fix automatic sharding for standalone AMD jobs and selected tests ci-infra#871.
  • caplog. Files that assert on logs sit in one-shard plans here, so their order in the process doesn't change.
  • Timeouts unchanged. timeout_in_minutes stays per job. Fallback-aware timeouts belong in a central timeout setting.

🤖 Generated with Claude Code


Pull Request Checklist
  • I used vLLM's /pr-checklist skill. (Mandatory for agents, optional for humans).

  • AI assistance was used during the creation of this PR.

  • Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.

  • Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.

  • Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.

  • Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.

BEFORE SUBMITTING, PLEASE READ https://docs.vllm.ai/en/latest/contributing (anything written below this line will be removed by GitHub Actions)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Thang Nguyen <thangnguyenvn647@gmail.com>
@Thangnguyenvn98

Copy link
Copy Markdown
Contributor Author

/ci run

@mergify mergify Bot added the ci/build label Oct 29, 2026
@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #98461 for commit 60f7a90439b6.

@Thangnguyenvn98
Thangnguyenvn98 marked this pull request as ready for review October 30, 2026 01:01
@Thangnguyenvn98
Thangnguyenvn98 requested a review from a team October 30, 2026 01:01

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@khluu
khluu merged commit 15a9677 into vllm-project:main Oct 30, 2026
59 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants