Repository navigation
Fix automatic sharding for standalone AMD jobs and selected tests - #871
Merged
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com> Signed-off-by: khluu <khluu000@gmail.com>
khluu
marked this pull request as ready for review
October 29, 2026 21:45
Member
|
Agent said that "It silently turns MI300 Model Executor (amd-model-executor) from 1 job into 4 shards on every vLLM build, and that has never run on GPU" and that this particularly sharding layout has not been tested yet, but I think that this is exactly what this PR is trying to do 😅 |
AndreasKaratzas
approved these changes
Oct 29, 2026
This was referenced Oct 30, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Standalone AMD jobs return from the generator before automatic sharding is applied. Also, an explicitly selected parametrized test is always kept whole, even when the exact command has per-test timings. Together these prevent the two AMD fusion jobs in vllm-project/vllm#64181 from splitting.
Route standalone native AMD jobs through the existing planner and allow selected tests to split when timings match the exact command. Keep the original pytest arguments, explicit parallelism, and unsupported-runtime exclusions.
Validation
python -m pytest buildkite/tests/pipeline_generator -q, run with the existing virtual environment).124170fbf4daf8d9433dad22bf1a9e7f5a7565e2. All six test jobs passed.git diff --checkpassed. Broader Ruff rules report pre-existing findings; unrelated formatting was excluded.Scope and review
This is a prerequisite for part of vllm-project/vllm#64181, not a claim that the whole enrollment batch is ready. Script-based jobs, pooling overhead, and the indivisible DeepSeek evaluation remain separate work.
Searched open ci-infra sharding PRs; #855 changes timing terminology and #825 fixes plugin import paths, neither addresses these execution paths. No duplicate fix found.
AI assistance: Codex prepared this change and ran the local checks. Human review is pending; measured GPU timing limitations are documented above. No model behavior or evaluation thresholds change.