Skip to content

[Model] Remove Keye-VL and Keye-VL-1.5 - #64287

Merged
hmellor merged 1 commit into
vllm-project:mainfrom
hmellor:remove-keye
Oct 28, 2026
Merged

hmellor merged 1 commit into
vllm-project:mainfrom
hmellor:remove-keye

Conversation

@hmellor

@hmellor hmellor commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Overview

Remove KeyeForConditionalGeneration (Keye-VL-8B-Preview) and KeyeVL1_5ForConditionalGeneration (Keye-VL-1.5-8B). Over 90% of their Hub downloads come from vLLM CI, and Keye-VL-1.5's remote image processor breaks on Transformers 5.21 (#64049).

Model Released on the Hub Added to vLLM
Keye-VL-8B-Preview 2025-06-26 (16 months ago) 2025-07-02 (#20126)
Keye-VL-1.5-8B 2025-08-26 (14 months ago) 2025-09-01 (#23838)

Claims

  • Both architectures are removed from the registry, tests, examples and supported models docs.
  • Both are added to _PREVIOUSLY_SUPPORTED_MODELS with 0.33.0, the last release that has them (the v0.33.0 release branch is already cut), so loading one raises a clear error.
  • Kwai's newer Keye checkpoints (Keye-VL-2.0, Keye-VL-671B) use architectures vLLM never supported, so nothing else is affected.
  • Supersedes [Bugfix] Fix missing f-string in Keye smart_resize aspect-ratio error message #49676, which fixes an error message in keye_vl1_5.py.

Validation

  • pytest tests/models/test_registry.py: 429 passed, 9 skipped.
  • Resolving KeyeVL1_5ForConditionalGeneration raises "was supported in vLLM until v0.33.0".
  • pre-commit run passes, and no Keye references remain (git grep -E "Keye|keye_").

Pull Request Checklist
  • I used vLLM's /pr-checklist skill. (Mandatory for agents, optional for humans).

  • AI assistance was used during the creation of this PR.

  • Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.

  • Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.

  • Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.

  • Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@mergify

mergify Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Documentation preview: https://vllm--64287.org.readthedocs.build/en/64287/

@mergify mergify Bot added documentation Improvements or additions to documentation multi-modality Related to multi-modality (#4194) labels Oct 28, 2026
@hmellor
hmellor marked this pull request as ready for review October 28, 2026 14:04

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@hmellor

hmellor commented Oct 28, 2026

Copy link
Copy Markdown
Member Author

/ci run

@hmellor
hmellor enabled auto-merge (squash) October 28, 2026 14:07
@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #97972 for commit abc8979e03ef.

@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 28, 2026
@hmellor hmellor mentioned this pull request Oct 28, 2026
5 of 6 tasks
@hmellor
hmellor disabled auto-merge October 28, 2026 15:39
@hmellor
hmellor merged commit c91ab83 into vllm-project:main Oct 28, 2026
136 checks passed
@hmellor
hmellor deleted the remove-keye branch October 28, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants