Repository navigation
[CI] Bump Transformers version to 5.21.1 - #64049
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Member
Author
|
/ci run nightly |
|
✅ Triggered Buildkite CI #97620 for commit |
…formers 5.21 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This was referenced Oct 28, 2026
Merged
Picks up huggingface/transformers#50080. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Member
Author
|
/ci run nightly |
|
✅ Triggered Buildkite CI #97989 for commit |
nvidia-nvshmem-cu13 3.8.0 depends on it, so pip-compile-rocm started emitting it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Member
Author
|
/ci run nightly |
|
✅ Triggered Buildkite CI #97995 for commit |
6 tasks done
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Member
Author
|
/ci run |
|
✅ Triggered Buildkite CI #98263 for commit |
hmellor
marked this pull request as ready for review
October 29, 2026 11:00
Member
Author
|
cc @AndreasKaratzas the penultimate run used nightly CI and the only failures were present on ci.vllm.ai/alerts. I'm only using regular CI for the final merge to save time/cost |
DarkLight1337
approved these changes
Oct 29, 2026
Member
Author
|
/ci run |
|
✅ Triggered Buildkite CI #98274 for commit |
Isotr0py
approved these changes
Oct 29, 2026
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Bump Transformers to v5.21.1. Follows #61983.
Claims
requirements/common.txtallowstransformers >= 5.16.1, < 5.22.0.rope_scalingsetter for configs that assign it during init huggingface/transformers#50080 on top of 5.21.0. That fixes therope_scalingsetter regression from Deprecate rope_scaling assignment and normalize legacy RoPE keys huggingface/transformers#49515, which broke remote-code configs (Phi-3/3.5, Phi-4-multimodal, InternVL2, InternLM2.5, Step-3.7),Step5Configand the EAGLE3 speculators config (rope_theta=None).downsample_modetofind_best_resize/get_refine_sizeon 5.21, which made it required and changed alignment in"4x"mode.convert_to_rgbrejects tensors); Keye was removed in [Model] Remove Keye-VL and Keye-VL-1.5 #64287.Validation
/ci run nightlyon 5.21.0 (build 97620): 37 of 41 failures came from the bump. The other 4 also fail onmain.test_common.py -k MiniCPM-V-4_6: 3 failed on Transformersmainwithout the fix, 3 passed with it, and passes on 5.20.mainvsmain+ [Bugfix][Spec Decode] Scope MTP completeness checks for Kimi K3 #50080: only Step-5-Preview andnm-testing/Llama3_2_1B_speculator.eagle3change onmain, and both match 5.20 with the fix.pip-compileskipped locally); CI pre-commit verifies the lockfiles./ci run nightlyonv5.21-release(build 97995): 7 failures, all also failing onmain(HiSparse/MLA attention, Humming Activation, BMG V1)./ci runon 5.21.1 (identical code tov5.21-release): pending.Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.
🤖 Generated with Claude Code