Repository navigation
[Chore] Use upstream Transformers InklingProcessor - #61883
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
5 of 6 tasks
Isotr0py
approved these changes
Oct 16, 2026
Member
Author
|
/ci run |
hmellor
enabled auto-merge (squash)
October 16, 2026 08:20
|
✅ Triggered Buildkite CI #95352 for commit |
michael-gpu
pushed a commit
to practical-inference/vllm-ampere-extended
that referenced
this pull request
Oct 20, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Split from #60823: deletes the vendored Inkling processor and builds Inkling's multimodal inputs with upstream Transformers
InklingProcessor.Related PRs:
No other open PR touches
vllm/models/inkling/common/mm_preprocess.pyor the vendored processor.Claims
vllm/transformers_utils/processors/inkling.py(504 lines).InklingProcessingInfo.get_hf_processorloads upstreamInklingProcessorfrom the checkpoint, which ships in every Transformers version vLLM supports (>= 5.16.1).InklingProcessor._extract_dmel_bins(private) quantises them to dMel ids. The dMel parameters now come from the checkpoint'spreprocessor_config.jsoninstead of being copied from the vLLM config.input_audio_featuresstays), so the model code and the Rust frontend, which sends Inkling audio under that key, are untouched. The only output difference is that the dMel ids are int32 instead of float32 holding the same integers; the audio tower casts to int32 anyway.main.Validation
Processor outputs on CPU,
thinkingmachines/Inkling-NVFP4,mainvs this PR: 4 images (224x224 to 1920x1080, and 37x501), 3 audio clips at 16 kHz (1 s to 31 s), one 44.1 kHz clip, and a mixed image + audio prompt. Prompt token ids,pixel_valuesandnum_patchesare identical; the dMel ids have identical values.Greedy decode,
thinkingmachines/Inkling-Small-NVFP4on 2x B200 (TP2),transformers5.19.0, FlashInfer autotuning off, 128 tokens with logprobs:mainrun 1 vs run 2mainvs this PR"Identical" means the same prompt token count, text and logprobs (max |Δ logprob| = 0). With FlashInfer autotuning on, two
mainlaunches already differ from each other, so it was turned off.Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.
🤖 Generated with Claude Code