Repository navigation
Conversation
Split from vllm-project#60823. Deletes the vendored MiniMax-M3 config and ports the model code to the upstream Transformers schema. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
requested review from
AndreasKaratzas,
WoosukKwon,
dllehr-amd,
hongxiayang,
mgoin,
tjtanaa,
tlrmchlsmth,
yewentao256 and
zyongye
as code owners
October 15, 2026 10:25
hmellor
added a commit
to hmellor/vllm
that referenced
this pull request
Oct 15, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
5 of 6 tasks
Standalone MTP checkpoints (model_type minimax_m3_mtp) copy the main model's per-layer lists, which upstream MiniMaxM3VLTextConfig rejects for a 1-layer config. A small subclass keeps the leading entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
6 tasks done
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Split from #60823: replaces the vendored MiniMax-M3 config and ports the MiniMax-M3 code to the upstream Transformers
MiniMaxM3VLConfigschema.Related PRs:
Claims
MiniMaxM3VLConfigforminimax_m3_vlin_CONFIG_REGISTRY, because the hub remote code uses the old schema.vllm/transformers_utils/configs/minimax_m3.pyshrinks toMiniMaxM3MTPConfig, a subclass of upstreamMiniMaxM3VLTextConfigfor standalone MTP checkpoints (model_type: "minimax_m3_mtp"). These copy the main model's 60-entry per-layer lists, which upstream rejects for a 1-layer config, so the subclass keeps the leading entries the MTP layer reads. No public checkpoint uses this format, but private ones may.layer_types/mlp_layer_typesreplacesparse_attention_config["sparse_attention_freq"]/moe_layer_freq.index_*fields replace the rest ofsparse_attention_config.rope_parametersreplacesrope_theta/partial_rotary_factor/rope_scaling.spatial_merge_size/temporal_patch_sizedirectly.hidden_act="silu"and dropsswiglu_beta, so theswigluoaicheck is removed and beta is fixed at 1.0, the value in every checkpoint and in the upstream reference model.sparse_init_blockandsparse_score_typefall back to the indexer's defaults (0,"max"), which also match every checkpoint.lukealonso/MiniMax-M3-NVFP4) failed with "Unsupported activation: silu"; they now build.main, and GSM8k and GPQA Diamond match.Validation
nvidia/MiniMax-M3-NVFP4on 8x B200,main(b965ee564d) on GPUs 0-3 vs this branch on GPUs 4-7, TP4 each,transformers5.19.0, FlashInfer autotuning off.mainConfig and meta-device model dumps with the
transformers-upgradeskill's scripts, forMiniMaxAI/MiniMax-M3,MiniMaxAI/MiniMax-M3-MXFP8,nvidia/MiniMax-M3-NVFP4andamd/MiniMax-M3-MXFP4: 0 diffs in parameters and module attributes, for both the main model and the MTP draft (--speculative-config '{"method": "mtp", "num_speculative_tokens": 1}'), including a draft loaded from a synthetic standalone MTP checkpoint in the old schema.lukealonso/MiniMax-M3-NVFP4goes from the error above to building. The config diffs are only the schema renames. MTP was not served: no public MiniMax-M3 checkpoint ships MTP weights. The ROCm path was not served either; it is covered by the meta-device build andtest_fused_shared_expert.py, which builds the AMDMiniMaxM3Model.Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.
🤖 Generated with Claude Code