Repository navigation
[ROCm][Kimi-K3] Don't read W_UK_T before weight loading in the MLA wrapper - #61654
Merged
Merged
Conversation
…apper Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
Rohan138
requested review from
dllehr-amd,
hongxiayang and
tjtanaa
as code owners
October 14, 2026 16:36
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Collaborator
Author
|
/ci run |
|
✅ Triggered Buildkite CI #94873 for commit |
Collaborator
Author
|
/ci run |
Collaborator
Author
|
merged main and rerunning CI to pick up fix from #61650 |
|
✅ Triggered Buildkite CI #94893 for commit |
AndreasKaratzas
approved these changes
Oct 14, 2026
AndreasKaratzas
enabled auto-merge (squash)
October 14, 2026 18:48
AndreasKaratzas
pushed a commit
to AndreasKaratzas/vllm
that referenced
this pull request
Oct 16, 2026
…apper (vllm-project#61654) Signed-off-by: Rohan138 <rohanpotdar138@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Andreas Karatzas <AndreasKaratzas@users.noreply.github.com>
michael-gpu
pushed a commit
to practical-inference/vllm-ampere-extended
that referenced
this pull request
Oct 20, 2026
…apper (vllm-project#61654) Signed-off-by: Rohan138 <rohanpotdar138@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a Kimi-K3 startup crash on ROCm (
'MLAAttention' object has no attribute 'W_UK_T') that appears once #53123 turns AITER FP8 BMM off by default.Claims
KimiK3MultiHeadLatentAttentionWrapper._fused_qk_prep_supported()no longer readsattn.W_UK_Tin__init__.Validation
Kimi-K3-pruned75-DSpark-AITER-TP4, amd-ci #14622._fused_qk_prep_supportedagainst annn.Modulefake MLA attention in that build's CI image (includes [ROCm] Disable AITER FP8/FP4 BMM for MLA by default #53123):AttributeError: W_UK_TDetails
_fused_qk_prep_supported()runs in__init__, butMLAAttention.W_UK_Tis only created inprocess_weights_after_loading. Before #53123, FP8 BMM was on by default, so the expression short-circuited and never read it.process_weights_after_loadingalways createsW_UK_Twhen FP4 and FP8 BMM are both off, so the check isn't needed. Usinggetattr(..., None)instead would have turned the fused path off for every such config. No open PR fixes this; #60110 edits_fused_decodebut not this gate.Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.
🤖 Generated with Claude Code