Repository navigation
[ROCm][CI] Add dtype to the KDA metadata test's fake model config - #61650
Merged
AndreasKaratzas merged 2 commits intoOct 14, 2026
Merged
Conversation
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Collaborator
Author
|
/ci run |
|
✅ Triggered Buildkite CI #94859 for commit |
AndreasKaratzas
approved these changes
Oct 14, 2026
AndreasKaratzas
enabled auto-merge (squash)
October 14, 2026 16:30
6 tasks done
arpera
approved these changes
Oct 14, 2026
arpera
left a comment
arpera
left a comment
Contributor
There was a problem hiding this comment.
Verified locally the same fix. Fix works. LGTM
6 tasks done
AndreasKaratzas
pushed a commit
to AndreasKaratzas/vllm
that referenced
this pull request
Oct 16, 2026
…lm-project#61650) Signed-off-by: Rohan138 <rohanpotdar138@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Andreas Karatzas <AndreasKaratzas@users.noreply.github.com>
michael-gpu
pushed a commit
to practical-inference/vllm-ampere-extended
that referenced
this pull request
Oct 20, 2026
…lm-project#61650) Signed-off-by: Rohan138 <rohanpotdar138@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes
test_kda_recoverssm_startup_metadata_flow_without_modelon MI300/MI355, broken by #60645.Broken CI build on main: https://buildkite.com/vllm/ci/builds/94799/canvas?jid=01a13a82-312f-41d0-a166-9d38788a7f14&tab=output
Claims
dtypeto the test's fakemodel_config; no non-test changes.Validation
pytest models/kimi_k3/test_kda_metadata.pyon MI300X with the AMD CI image from amd-ci #14622 (includes #60645):Same failure in CI:
AttributeError: 'types.SimpleNamespace' object has no attribute 'dtype'(MI300 and MI355 Kimi K3 jobs).Details
On MI3xx, #60645's
_resolve_gdn_prefill_backendcalls_aiter_flydsl_unsupported_reasons, which readsvllm_config.model_config.dtype. The test'sSimpleNamespaceconfig had nodtype. Real configs always do. No open PR fixes this; #61250 edits the same test file but not this config.Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.
🤖 Generated with Claude Code