Repository navigation
Conversation
Retain every prompt row when routed-expert output is enabled. Decoder replay cannot recover routing decisions for rows whose computation was omitted, so reuse the prompt-logprobs keep-row policy. Extend the existing replay batch tests for eager and PIECEWISE execution. Validation: isolated CPU admission and row-selection checks reproduced six failures on main and passed all twenty cases with the fix. Applicable pre-commit checks passed. GPU/model runs were not repeated for this split. Signed-off-by: Ronald1995 <ronaldautomobile@163.com>
6 tasks done
Ronald1995
marked this pull request as ready for review
October 15, 2026 04:42
Ronald1995
requested review from
AndreasKaratzas,
DarkLight1337 and
ywang96
as code owners
October 15, 2026 04:42
|
✅ @Ronald1995, CI is now available for this PR.
|
Collaborator
Author
|
/ci run |
|
✅ Triggered Buildkite CI #95029 for commit |
Collaborator
Author
|
/ci retry |
|
✅ Queued 1 failed job(s) for retry in Buildkite CI #95029. |
aoshen02
approved these changes
Oct 15, 2026
aoshen02
enabled auto-merge (squash)
October 15, 2026 07:42
Collaborator
Author
|
/ci run |
|
❌ This PR is 7 commits behind upstream |
Collaborator
Author
|
/ci run |
|
✅ Triggered Buildkite CI #95089 for commit |
2 of 6 tasks
Open
2 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Keep every prefill routing row when DeepSeek V4.1 decoder replay runs with returned routed experts enabled. Extracted from #61388 as a standalone fix based on
main.Claims
Validation
mainreproduce 6 failures / 14 passes, including a 300-row prefill incorrectly reduced to 128 rows.git diff --check: passed with local UTF-8/Git Bash interpreter adaptations.GPU/model runs were not repeated for the split. CPU checks stop at the row-selection boundary and substitute configuration/base-state/input-gather fixtures; they do not validate CUDA kernels or attention numerics. The GPU regression remains in the existing CI-tethered suite:
Details
Decoder replay can normally skip older prefill rows when only final logits are needed. Returned routing needs every accepted token's decisions; scattering the remaining rows cannot recover computations that never ran. Mark R3 requests as requiring every row when admitted, using the existing keep-row policy.
R3-enabled replay therefore retains prefill work that could otherwise be trimmed. No throughput measurement is claimed.
Duplicate-work checks refreshed open PR searches for
61388 in:body, routed-expert capture, and decoder replay. #52902 adds API consistency tests, #57184 handles DBO staging/offsets, and #56778 implements terminal transport; they do not implement this NVIDIA V4.1 admission policy. The same fix has been removed from #61388, so this is its single review location.AI assistance was used to split and validate the existing fix.
Pull Request Checklist
/pr-checklistskill.