Repository navigation
Conversation
5 of 6 tasks
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
Extract the focused fix and regression coverage from vllm-project#58968. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
whx-sjtu
force-pushed
the
whx/mrv2-full-read-context-20261008
branch
from
October 12, 2026 03:41
a78375b to
61398a9
Compare
whx-sjtu
marked this pull request as ready for review
October 12, 2026 14:42
whx-sjtu
requested review from
WoosukKwon,
njhill and
yewentao256
as code owners
October 12, 2026 14:42
5 of 6 tasks
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Pass the actual FULL graph mode to MRV2's synchronous KV-load pre-forward hook, so a connector can wait for its loads before graph replay bypasses Python layer hooks. This is the standalone FULL-context fix extracted from #58968.
Rebased onto main
bfa7e5b7afe40ebe48288801a2baf5c1135cd881. This remains an independent child of closed #58968.Claims
kv_connector.pre_forward()under a forward context whose runtime mode isCUDAGraphMode.FULLon the FULL replay branch.Validation
Validated on
61398a91a907fafb364cb0ffd7b2f902844abdb3(2026-10-12): 17 passed. Changed-file pre-commit passed, including mypy for Python 3.11 and test/CI tethering checks.Fresh negative control on the current main: the two new FULL-context cases fail for DP sizes 1 and 2; both pass here. The tests check that
pre_forwardobserves FULL mode without triggering another DP synchronization. Rebase preserves #60754's(scheduler_output, input_batch, attn_metadata)interface.Exact-source FULL-graph PD/RDMA execution remains pending. Eager accuracy and a mocked replay boundary do not establish that result.
The eight independent PRs compose on this same main. The combined CPU suite passes 344 tests, with 33 skips (32 ROCm/aiter-gated connector cases and one GPU LLM case) and one model-loading deselection. Counts overlap with the independent suites.
Details
ActiveKVConnectorstarts synchronous loads duringpre_forward(). Without a caller-provided context it constructs a default context. MoRI's READ path distinguishes FULL replay, which must finish all required reads before replay, from execution that can wait through per-layer hooks. The missing FULL context can therefore select the wrong existing wait path.This changes only the FULL call site and its tests. It adds no connector capability, does not introduce a new READ barrier and does not depend on the MultiConnector ownership or speculative-readiness split. #57700 explicitly left this context correction to #58968; #48464 concerns MRV1 imperative lifecycle helpers, not this MRV2 replay call site.
Merge impact: reversible code change; MRV2 FULL pre-forward hooks. An existing connector's FULL-specific waiting behavior can now run at this call site. No throughput or latency equivalence is claimed.
#60808 changes MoRIIO to await all READs before any forward; if it lands first, MoRI no longer relies on FULL mode for that decision. This PR separately preserves the common MRV2 replay-context contract. #60637 handles output publication after draft writes, not input loading.
AI assistance was used for implementation, rebase, regression checks and this description. Human line-by-line review and the runtime acceptance items above remain pending. No performance improvement is claimed.
Pull Request Checklist
/pr-checklistskill. (Mandatory for agents, optional for humans).