Repository navigation
Conversation
|
#57700 has been reduced to MoRIIO DSpark enablement plus the shared NIXL clipping The removed FULL pre-forward context change matches the approach here, so |
|
Could we extend The proposed delta is small: change the guard to not in ("LBHNC", "LBNHC") and extend the existing parameterized test with LBHNC attention-import, state-only, and no-pending-receive cases. This passed 57 related tests; restoring the original guard fails only the new LBHNC attention-import case. Independent byte-range checks also confirmed complete page coverage for both layouts. In fact, I prefer a small follow-up PR to handle sync-load zeroing bugfix which could narrow to 40 lines with some other test code, as this PR is too big and the merging process might be slow, and keeping #57700 focused on DSpark enablement. |
|
This pull request has merge conflicts that must be resolved before it can be |
Let synchronous connectors identify fully initialized destination blocks after allocation. Reuse the scheduler zeroing exclusions so out-of-band READs cannot race GPU zeroing, including both LBHNC and LBNHC hybrid attention layouts. Extract the narrow fix from vllm-project#58968 using Yichao Zhu's reference commit 2656810. MultiConnector delegates only to the selected loader; state-only imports and other connectors retain zeroing. Assisted-by: OpenAI Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Yichao Zhu <Yichao.Zhu@amd.com> Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
Place the selected-loader regression after an unchanged existing test so the standalone fix and vllm-project#58968 merge without overlapping additions. Test behavior is unchanged. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
Extract the process-based discovery sender from vllm-project#58968 onto main. Preserve the discovery payload and rank-zero startup guard, stop the helper on explicit shutdown or parent pipe EOF, and retain the GIL-starvation and parent-exit lifecycle regressions. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
Co-authored-by: Yichao Zhu <Yichao.Zhu@amd.com> Co-authored-by: Codex <noreply@openai.com> Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
Co-authored-by: Codex <noreply@openai.com> Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
Remove the connector hook, scheduler exclusions, and their tests from this broader PD branch. The independent MoRIIO zeroing fix includes both LBHNC and LBNHC and remains part of the complete hybrid READ validation stack. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
Let synchronous connectors identify fully initialized destination blocks after allocation. Reuse the scheduler zeroing exclusions so out-of-band READs cannot race GPU zeroing, including both LBHNC and LBNHC hybrid attention layouts. Extract the narrow fix from vllm-project#58968 using Yichao Zhu's reference commit 2656810. MultiConnector delegates only to the selected loader; state-only imports and other connectors retain zeroing. Assisted-by: OpenAI Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Yichao Zhu <Yichao.Zhu@amd.com> Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
Place the selected-loader regression after an unchanged existing test so the standalone fix and vllm-project#58968 merge without overlapping additions. Test behavior is unchanged. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
Let synchronous connectors identify fully initialized destination blocks after allocation. Reuse the scheduler zeroing exclusions so out-of-band READs cannot race GPU zeroing, including both LBHNC and LBNHC hybrid attention layouts. Extract the narrow fix from vllm-project#58968 using Yichao Zhu's reference commit 2656810. MultiConnector delegates only to the selected loader; state-only imports and other connectors retain zeroing. Assisted-by: OpenAI Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Yichao Zhu <Yichao.Zhu@amd.com> Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
Place the selected-loader regression after an unchanged existing test so the standalone fix and vllm-project#58968 merge without overlapping additions. Test behavior is unchanged. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
Separate the three independently reviewable lifecycle fixes from vllm-project#58968. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
Extract the independent fix and its regressions from vllm-project#58968. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
Extract the independent fix and its regressions from vllm-project#58968. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
Extract the independent fix and its regressions from vllm-project#58968. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
Extract the focused fix and regression coverage from vllm-project#58968. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
Extract the independent fix and its regressions from vllm-project#58968. Co-authored-by: Codex <noreply@openai.com> Co-authored-by: Yichao Zhu <Yichao.Zhu@amd.com> Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
Separate the three independently reviewable lifecycle fixes from vllm-project#58968. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
Extract the focused fix and regression coverage from vllm-project#58968. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
Extract the independent fix and its regressions from vllm-project#58968. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
Overview
Superseded by eight focused, independently main-based draft PRs. All remaining fixes have been extracted; use the child PRs for review and integration. This PR is closed without merging, and its original branch/head remains available for history.
Claims
The five latest PRs are based on main
194da61de1769c28bfad2b6642c60cc7eca544ddand have no commit dependency on each other or on the previous three.Validation
Each fix has a production-only negative control. Changed-file pre-commit, including mypy, passed for every branch. All eight commits cherry-pick without conflicts, and their combined suite passed 343 tests, with 1 GPU-only skip and 1 model-loading deselection. Individual counts overlap and must not be added.
The five-way composition preserves all nine files of the residual diff when applied to the same main base, except for moving the READ eligibility regression to the existing scheduler suite and reusing its fixture. Source behavior and every regression case remain accounted for.
These are CPU results. No new GPU/RDMA/model evaluation, profiling or performance experiment was dispatched for this extraction. Historical combined-stack evaluations described in this PR's discussion do not validate the new child commits in isolation.
Details
Preserved residual source:
fc9f0ca96d3990cc1c82600a68b8e92f74e5eecc. The earlier combined headb5626f70f21579165f535da84fd036c131223700also remains in history. No force-push, branch deletion or merge was needed to retire this parent.Evidence classification is explicit in each child: READ eligibility was found in a single-machine recovery experiment; port collision has CI stderr and native-listener reproduction; shared MR and hybrid cleanup have CPU reproductions without isolated field attribution; EOF text loss is deterministic in the real parser, without original generated-token evidence attributing warmup empty responses to it.
The connector-interface discussion is isolated in #60637. Other previously separated scopes remain #59164 (sync-load zeroing) and #59441 (discovery heartbeat). Producer source retention until ACK belongs to #56465. The MR child documents integration requirements for future hybrid WRITE in #60544; the EOF child documents overlap with the broader Parser Engine migration #50229.
AI assistance was used for implementation, extraction, tests and review. All child PRs remain drafts pending final human review and exact-source runtime validation.
Pull Request Checklist
/pr-checklistskill. (Mandatory for agents, optional for humans).