Skip to content

[Agents] Expose PR checklist skill to Claude - #59638

Merged
benchislett merged 1 commit into
vllm-project:mainfrom
mgoin:link-pr-checklist-skill
Oct 1, 2026
Merged

benchislett merged 1 commit into
vllm-project:mainfrom
mgoin:link-pr-checklist-skill

Conversation

@mgoin

@mgoin mgoin commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

Overview

Symlink .claude/skills/pr-checklist to .agents/skills/pr-checklist so Claude Code registers the skill added in #57084.

Claims

  • /pr-checklist becomes invocable in Claude Code. It was the only skill under .agents/skills/ without a .claude/skills/ link, although AGENTS.md and the PR template make it mandatory for agents.

Validation

  • With the link in place, a Claude Code session lists pr-checklist as an available skill and /pr-checklist loads SKILL.md; before, it was absent.
  • comm -23 <(ls .agents/skills) <(ls .claude/skills) prints nothing.
  • Pre-commit passed. No runtime code is touched, so tests, evals, and benchmarks are not applicable.

Details

Same one-symlink change as #55028 made for triton-kernel-writing. The skill's relative doc links (../../../docs/...) resolve identically through the link because both paths sit at the same depth.

Not a duplicate: no open PR adds this link. The open skill PRs (#57786, #57088, #50527, #48925) touch other skills.


Pull Request Checklist
  • I used vLLM's /pr-checklist skill. (Mandatory for agents, optional for humans).

  • AI assistance was used during the creation of this PR.

  • Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.

  • Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.

  • Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.

  • Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.

🤖 Generated with Claude Code

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: mgoin <mgoin64@gmail.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mgoin mgoin added the agents Related to information for agents label Oct 1, 2026
@mgoin

mgoin commented Oct 1, 2026

Copy link
Copy Markdown
Member Author

/ci run

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

✅ Triggered Buildkite CI #92439 for commit fd16ee367596.

@benchislett
benchislett self-requested a review October 1, 2026 16:26
@benchislett
benchislett enabled auto-merge (squash) October 1, 2026 16:27
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 1, 2026
@benchislett
benchislett merged commit 362cfb7 into vllm-project:main Oct 1, 2026
27 checks passed
@mgoin
mgoin deleted the link-pr-checklist-skill branch October 1, 2026 16:59
@ZJY0516 ZJY0516 mentioned this pull request Oct 6, 2026
6 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents Related to information for agents ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants