Skip to content

[CI Bug] Fix main pre-commit issue - #59429

Closed
yewentao256 wants to merge 1 commit into
mainfrom
wentao-fix-main-precommit
Closed

yewentao256 wants to merge 1 commit into
mainfrom
wentao-fix-main-precommit

Conversation

@yewentao256

Copy link
Copy Markdown
Member

Purpose

Main CI issue

$ mypy --python-version 3.13 
tests/multimodal/test_cache.py:812: error: Value of type "MultiModalKwargsItem | None" is not indexable  [index]
tests/multimodal/test_cache.py:813: error: Value of type "MultiModalKwargsItem | None" is not indexable  [index]
tests/multimodal/test_cache.py:900: error: Argument 1 to "validate_input_item" of "ShmObjectStoreSenderCache" has incompatible type "MultiModalKwargsItem | None"; expected "MultiModalKwargsItem"  [arg-type]
tests/multimodal/test_cache.py:903: error: Value of type "MultiModalKwargsItem | None" is not indexable  [index]
tests/multimodal/test_cache.py:905: error: Argument 1 to "_with_elem" has incompatible type "MultiModalKwargsItem | None"; expected "MultiModalKwargsItem"  [arg-type]
tests/multimodal/test_cache.py:905: error: Unsupported operand types for ^ ("list[NestedTensors]" and "int")  [operator]
tests/multimodal/test_cache.py:905: error: Unsupported operand types for ^ ("list[Any]" and "int")  [operator]
tests/multimodal/test_cache.py:905: error: Unsupported operand types for ^ ("tuple[Any, ...]" and "int")  [operator]
tests/multimodal/test_cache.py:905: note: Left operand is of type "list[NestedTensors] | list[Any] | Any | tuple[Any, ...]"
tests/multimodal/test_cache.py:906: error: Argument 1 to "_with_elem" has incompatible type "MultiModalKwargsItem | None"; expected "MultiModalKwargsItem"  [arg-type]
tests/multimodal/test_cache.py:907: error: Argument 1 to "_with_elem" has incompatible type "MultiModalKwargsItem | None"; expected "MultiModalKwargsItem"  [arg-type]
tests/multimodal/test_cache.py:908: error: Argument 1 to "_with_elem" has incompatible type "MultiModalKwargsItem | None"; expected "MultiModalKwargsItem"  [arg-type]
tests/multimodal/test_cache.py:909: error: Argument 1 to "_with_elem" has incompatible type "MultiModalKwargsItem | None"; expected "MultiModalKwargsItem"  [arg-type]
tests/multimodal/test_cache.py:911: error: Value of type "MultiModalKwargsItem | None" is not indexable  [index]
tests/multimodal/test_cache.py:918: error: Argument 1 to "validate_input_item" of "ShmObjectStoreSenderCache" has incompatible type "MultiModalKwargsItem | None"; expected "MultiModalKwargsItem"  [arg-type]
tests/multimodal/test_cache.py:922: error: Argument 1 to "validate_input_item" of "ShmObjectStoreSenderCache" has incompatible type "MultiModalKwargsItem | None"; expected "MultiModalKwargsItem"  [arg-type]
tests/multimodal/test_cache.py:945: error: Argument 1 to "_with_elem" has incompatible type "MultiModalKwargsItem | None"; expected "MultiModalKwargsItem"  [arg-type]
tests/multimodal/test_cache.py:973: error: Argument 1 to "feature" has incompatible type "MultiModalKwargsItem | None"; expected "MultiModalKwargsItem"  [arg-type]
tests/multimodal/test_cache.py:983: error: Argument 1 to "feature" has incompatible type "MultiModalKwargsItem | None"; expected "MultiModalKwargsItem"  [arg-type]
Found 18 errors in 1 file (checked 1171 source files)
$ mypy --python-version 3.13 --follow-imports skip tests

This PR fixes the issue

(yewentao256) [yewentao256@nm-ore-b300-01 vllm-source]$ pre-commit run --hook-stage manual mypy-3.13 -a
Run mypy for Python 3.13.................................................Passed

Signed-off-by: yewentao256 <zhyanwentao@126.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@yewentao256 yewentao256 added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 30, 2026
@mergify mergify Bot added multi-modality Related to multi-modality (#4194) bug Something isn't working labels Sep 30, 2026
@yewentao256

Copy link
Copy Markdown
Member Author

/ci run

@DarkLight1337

Copy link
Copy Markdown
Member

I'm already fixing this in #59426

@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #92146 for commit 00dccf6d8507.

@mgoin mgoin closed this Sep 30, 2026
@yewentao256
yewentao256 deleted the wentao-fix-main-precommit branch September 30, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants