Skip to content

[CI/Build] Fix pre-commit - #59426

Merged
mgoin merged 1 commit into
vllm-project:mainfrom
DarkLight1337:fix-precommit
Sep 30, 2026
Merged

[CI/Build] Fix pre-commit#59426
mgoin merged 1 commit into
vllm-project:mainfrom
DarkLight1337:fix-precommit

Conversation

@DarkLight1337

@DarkLight1337 DarkLight1337 commented Sep 30, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Purpose

Fix failing pre-commit caused by #59357

Test Plan

Test Result

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

@DarkLight1337
[CI/Build] Fix pre-commit
4c3ecc4 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 30, 2026
claude[bot]
claude Bot reviewed Sep 30, 2026
View reviewed changes

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@DarkLight1337

DarkLight1337 commented Sep 30, 2026

Copy link
Copy Markdown
Member Author

/ci run

@github-actions

github-actions Bot commented Sep 30, 2026

Copy link
Copy Markdown

✅ Triggered Buildkite CI #92142 for commit 4c3ecc4be8a6.

@mergify mergify Bot added the multi-modality Related to multi-modality (#4194) label Sep 30, 2026
@DarkLight1337 DarkLight1337 mentioned this pull request Sep 30, 2026
Closed
@mgoin
mgoin enabled auto-merge (squash) September 30, 2026 13:11
@mgoin
mgoin merged commit 677e3f5 into vllm-project:main Sep 30, 2026
35 of 38 checks passed
@DarkLight1337
DarkLight1337 deleted the fix-precommit branch September 30, 2026 13:48
ZJY0516 added a commit to ZJY0516/vllm that referenced this pull request Sep 30, 2026
@ZJY0516
Merge upstream/main to pick up the pre-commit fix (vllm-project#59426)
9293b44 
Signed-off-by: zjy0516 <riverclouds.zhu@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments
@mgoin mgoin mgoin approved these changes
@hmellor hmellor hmellor approved these changes
@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner
@NickLucche NickLucche Awaiting requested review from NickLucche NickLucche is a code owner
@shen-shanshan shen-shanshan Awaiting requested review from shen-shanshan shen-shanshan is a code owner

Assignees

No one assigned

Labels

multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DarkLight1337 @mgoin @hmellor